Use fully qualified collection names in roles/

Author: wbclark

roles/bats/tasks/bats_fetch_results.yml

@@ -1,12 +1,12 @@
 ---
 - name: "Find bats files"
-  find:
+  ansible.builtin.find:
     paths: "{{ bats_output_dir }}"
     patterns: "*.tap"
   register: bats_results
 
 - name: "Copy bats results"
-  fetch:
+  ansible.builtin.fetch:
     src: "{{ item.path }}"
     dest: "{{ bats_remote_dir }}"
   with_items: "{{ bats_results.files }}"

roles/bats/tasks/main.yml

@@ -1,49 +1,49 @@
 ---
 - name: "Load OS variables"
-  include_vars: "{{ ansible_os_family }}.yml"
+  ansible.builtin.include_vars: "{{ ansible_os_family }}.yml"
 
 - name: "install required packages"
-  package:
+  ansible.builtin.package:
     name: "{{ bats_packages }}"
     state: present
 
 - name: "Install bats from package"
-  package:
+  ansible.builtin.package:
     name: "bats"
     state: present
   ignore_errors: yes
 
 - name: "Get /usr/bin/bats stat"
-  stat:
+  ansible.builtin.stat:
     path: "/usr/bin/bats"
   register: bats_bin
 
 - name: "Clone bats"
-  git:
+  ansible.builtin.git:
     repo: "https://github.com/sstephenson/bats.git"
     dest: "{{ bats_git_dir }}"
   when: not bats_bin.stat.exists
 
 - name: "Install bats"
-  shell: "{{ bats_git_dir }}/install.sh /usr"
+  ansible.builtin.shell: "{{ bats_git_dir }}/install.sh /usr"
   args:
     creates: "/usr/bin/bats"
 
 - name: "Clone forklift"
-  git:
+  ansible.builtin.git:
     repo: "{{ bats_forklift_repo }}"
     dest: "{{ bats_forklift_dir }}"
     update: "{{ bats_update_forklift }}"
     version: "{{ bats_forklift_version }}"
 
 - name: "Bats output directory"
-  file:
+  ansible.builtin.file:
     state: "directory"
     path: "{{ bats_output_dir }}"
 
 - block:
     - name: "Run bats"
-      shell: "bats --tap {{ item }} > {{ bats_output_dir }}/{{ item }}.tap"
+      ansible.builtin.shell: "bats --tap {{ item }} > {{ bats_output_dir }}/{{ item }}.tap"
       args:
         chdir: "{{ bats_forklift_dir }}/bats"
       with_items:
@@ -56,7 +56,7 @@
       environment: "{{ bats_environment }}"
 
     - name: "Read results"
-      shell: "cat {{ bats_output_dir }}/{{ item }}.tap"
+      ansible.builtin.shell: "cat {{ bats_output_dir }}/{{ item }}.tap"
       register: "test_results"
       with_items:
         - "{{ bats_setup | select() | list }}"
@@ -65,14 +65,14 @@
         - "{{ bats_teardown | select() | list }}"
 
     - name: "Output test results"
-      debug:
+      ansible.builtin.debug:
         msg: "{{ test_results.results | join('\n', attribute='stdout') }}"
 
-    - include_tasks: 'bats_fetch_results.yml'
+    - ansible.builtin.include_tasks: 'bats_fetch_results.yml'
       when: bats_fetch_results
 
     - name: "Fail if tests didn't pass"
-      fail:
+      ansible.builtin.fail:
         msg: "Test failed, please see {{ bats_output_dir }}/ for more information"
       when: item.rc != 0
       with_items: "{{ test_output.results }}"

roles/cleanup_rh_ruby25/tasks/main.yml

@@ -1,6 +1,6 @@
 ---
 - name: Remove rh-ruby25 packages
-  package:
+  ansible.builtin.package:
     state: absent
     name: rh-ruby25*
   when:

roles/custom_certificates/tasks/issue.yml

@@ -1,6 +1,6 @@
 ---
 - name: 'Creating signing request'
-  command: >
+  ansible.builtin.command: >
     openssl req -new
       -newkey rsa:2048
       -nodes
@@ -11,7 +11,7 @@
     creates: "{{ custom_certificates_ca_directory_requests }}/{{ custom_certificates_hostname }}.csr"
 
 - name: 'Sign signing request'
-  command: >
+  ansible.builtin.command: >
       openssl ca
         -config "{{ custom_certificates_ca_directory }}/openssl.cnf"
         -batch

roles/custom_certificates/tasks/main.yml

@@ -1,45 +1,45 @@
 ---
 - name: 'Install openssl'
-  yum:
+  ansible.builtin.yum:
     name: openssl
     state: present
 
 - name: 'Create certs directory'
-  file:
+  ansible.builtin.file:
     path: "{{ custom_certificates_ca_directory_certs }}"
     state: directory
     mode: 0755
 
 - name: 'Create keys directory'
-  file:
+  ansible.builtin.file:
     path: "{{ custom_certificates_ca_directory_keys }}"
     state: directory
     mode: 0755
 
 - name: 'Create requests directory'
-  file:
+  ansible.builtin.file:
     path: "{{ custom_certificates_ca_directory_requests }}"
     state: directory
     mode: 0755
 
 - name: 'Deploy configuration file'
-  template:
+  ansible.builtin.template:
     src: openssl.cnf.j2
     dest: "{{ custom_certificates_ca_directory }}/openssl.cnf"
     owner: root
     group: root
     mode: 0644
 
 - name: 'Create index file'
-  file:
+  ansible.builtin.file:
     path: "{{ custom_certificates_ca_directory }}/index.txt"
     state: touch
     owner: root
     group: root
     mode: 0644
 
 - name: 'Ensure serial starting number'
-  template:
+  ansible.builtin.template:
     src: serial.j2
     dest: "{{ custom_certificates_ca_directory }}/serial"
     force: no
@@ -48,7 +48,7 @@
     mode: 0644
 
 - name: 'Creating CA certificate and key'
-  command: >
+  ansible.builtin.command: >
     openssl req -new
       -x509
       -nodes
@@ -60,14 +60,14 @@
     creates: "{{ custom_certificates_ca_directory_certs }}/custom_ca.crt"
 
 - name: 'Create server key'
-  command: >
+  ansible.builtin.command: >
     openssl genrsa
       -out "{{ custom_certificates_ca_directory_keys }}/{{ custom_certificates_server }}.key"
   args:
     creates: "{{ custom_certificates_ca_directory_keys }}/{{ custom_certificates_server }}.key"
 
 - name: 'Create server signing request'
-  command: >
+  ansible.builtin.command: >
     openssl req
       -new
       -config "{{ custom_certificates_ca_directory }}/openssl.cnf"
@@ -77,7 +77,7 @@
     creates: "{{ custom_certificates_ca_directory_requests }}/{{ custom_certificates_server }}.csr"
 
 - name: 'Create server certificate'
-  command: >
+  ansible.builtin.command: >
     openssl ca
       -create_serial
       -batch
@@ -88,7 +88,7 @@
   args:
     creates: "{{ custom_certificates_ca_directory_certs }}/{{ custom_certificates_server }}.crt"
 
-- include: issue.yml
+- ansible.builtin.include: issue.yml
   when: custom_certificates_hostnames is defined
   with_items: "{{ custom_certificates_hostnames }}"
   loop_control:

roles/customize_home/tasks/boostrap_script.yml

@@ -1,5 +1,5 @@
 - name: Make boostrap file executable
-  file:
+  ansible.builtin.file:
     dest: "{{ ansible_env.HOME }}/{{ customize_home_bootstrap_script }}"
     state: touch
     follow: false
@@ -8,5 +8,5 @@
 
 # The script is already on the machine, so using 'command' instead of 'script'. 'script' copies the script from the Ansible controller
 - name: Run custom bootstrap script
-  command: "{{ ansible_env.HOME }}/{{ customize_home_bootstrap_script }}"
+  ansible.builtin.command: "{{ ansible_env.HOME }}/{{ customize_home_bootstrap_script }}"
   when: bootstrap_script_path.stat.exists

roles/customize_home/tasks/clone_specified_repo.yml

@@ -1,20 +1,20 @@
 - name: Ensure temporary home directory does not exist
-  file:
+  ansible.builtin.file:
     path: "{{ ansible_env.HOME }}/tmp_custom_home/"
     state: absent
 
 - name: Clone specified repo into temporary custom home directory
-  git:
+  ansible.builtin.git:
     repo: "{{ customize_home_git_repo }}"
     dest: "{{ ansible_env.HOME }}/tmp_custom_home/"
 
 - name: Remove .git directory from temporary home directory after cloning
-  file:
+  ansible.builtin.file:
     path: "{{ ansible_env.HOME }}/tmp_custom_home/.git"
     state: absent
 
 - name: Remove .gitignore from temporary home directory after cloning
-  file:
+  ansible.builtin.file:
     path: "{{ ansible_env.HOME }}/tmp_custom_home/.gitignore"
     state: absent
 
@@ -24,6 +24,6 @@
   command: "cp -r {{ ansible_env.HOME }}/tmp_custom_home/. {{ ansible_env.HOME }}/"
 
 - name: Remove temporary home directory
-  file:
+  ansible.builtin.file:
     path: "{{ ansible_env.HOME }}/tmp_custom_home/"
     state: absent

roles/customize_home/tasks/main.yml

@@ -1,28 +1,28 @@
 - name: Check for specified files to copy to home directory
   become: false
-  stat:
+  ansible.builtin.stat:
     path: "{{ playbook_dir | dirname }}/user_devel_env_files/"
   delegate_to: localhost
   register: custom_home
 
 - name: Copy files to home directory
-  copy:
+  ansible.builtin.copy:
     src: "{{ playbook_dir | dirname }}/user_devel_env_files/"
     dest: "{{ ansible_env.HOME }}"
   when: custom_home.stat.isdir is defined and custom_home.stat.isdir
 
 - name: Remove .gitkeep file copied over from custom directory
-  file:
+  ansible.builtin.file:
     path: "{{ ansible_env.HOME }}/.gitkeep/"
     state: absent
 
-- include_tasks: clone_specified_repo.yml
+- ansible.builtin.include_tasks: clone_specified_repo.yml
   when: customize_home_git_repo is defined
 
 - name: Check custom bootstrap script exists
-  stat:
+  ansible.builtin.stat:
     path: "{{ ansible_env.HOME }}/{{ customize_home_bootstrap_script }}"
   register: bootstrap_script_path
 
-- include_tasks: boostrap_script.yml
+- ansible.builtin.include_tasks: boostrap_script.yml
   when: bootstrap_script_path.stat.exists

roles/debian_backports/tasks/main.yml

@@ -1,9 +1,9 @@
 ---
 - name: add distribution-specific variables
-  include_vars: "{{ ansible_distribution }}.yml"
+  ansible.builtin.include_vars: "{{ ansible_distribution }}.yml"
 
 - name: add backports repository
-  apt_repository:
+  ansible.builtin.apt_repository:
     repo: 'deb {{ debian_backports_uri }} {{ debian_backports_components }}'
     state: present
     update_cache: yes

roles/disable_firewall/tasks/main.yml

@@ -1,13 +1,13 @@
 ---
 - name: disable firewalld
-  service:
+  ansible.builtin.service:
     name: firewalld
     enabled: false
     state: stopped
   ignore_errors: true
 
 - name: disable iptables
-  service:
+  ansible.builtin.service:
     name: iptables
     enabled: false
     state: stopped