Fixes #XXXXX - Warn about unrecognized smart proxy features

When a smart proxy reports features that Foreman doesn't recognize
(e.g. from a proxy plugin not installed on the server), surface them
as Puppet warnings so administrators are aware of the mismatch.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: adamruzicka

lib/puppet/provider/foreman_smartproxy/rest_v3.rb

@@ -33,7 +33,12 @@ def create
       raise Puppet::Error.new(error_string)
     end
 
-    validate_features!(resource[:features], features_list(JSON.load(r.body)))
+    body = JSON.load(r.body)
+    if body.key?('unrecognized_features')
+      warn_unrecognized_features(body)
+    else
+      validate_features!(resource[:features], features_list(body))
+    end
   end
 
   def destroy
@@ -84,7 +89,11 @@ def refresh_features!
     # Replace proxy/feature list cache: pre-#19476 versions have limited responses, clear cache and re-fetch for them
     @proxy = body.key?('features') ? body : nil
 
-    validate_features!(resource[:features], features_list(proxy))
+    if proxy.key?('unrecognized_features')
+      warn_unrecognized_features(proxy)
+    else
+      validate_features!(resource[:features], features_list(proxy))
+    end
   end
 
   private
@@ -97,4 +106,10 @@ def validate_features!(expected, actual)
     missing_features = expected - actual
     raise Puppet::Error.new("Proxy #{resource[:name]} has failed to load one or more features (#{missing_features.join(", ")}), check /var/log/foreman-proxy/proxy.log for configuration errors") unless missing_features.empty?
   end
+
+  def warn_unrecognized_features(proxy_data)
+    unrecognized = proxy_data['unrecognized_features'] if proxy_data
+    return if unrecognized.nil? || unrecognized.empty?
+    Puppet.warning("Proxy #{resource[:name]} has features not recognized by Foreman: #{unrecognized.join(', ')}. If these features come from a Smart Proxy plugin, make sure Foreman has the plugin installed too.")
+  end
 end

spec/unit/foreman_smartproxy_rest_v3_spec.rb

@@ -40,6 +40,22 @@
       )
       provider.create
     end
+
+    it 'warns about unrecognized features' do
+      expect(provider).to receive(:request).with(:post, 'api/v2/smart_proxies', {}, kind_of(String)).and_return(
+        double(:code => '201', :body => {'features' => [{'name' => 'TFTP'}, {'name' => 'Logs'}], 'unrecognized_features' => ['NewFeature']}.to_json)
+      )
+      expect(Puppet).to receive(:warning).with(/Proxy proxy.example.com has features not recognized by Foreman: NewFeature/)
+      provider.create
+    end
+
+    it 'does not warn when there are no unrecognized features' do
+      expect(provider).to receive(:request).with(:post, 'api/v2/smart_proxies', {}, kind_of(String)).and_return(
+        double(:code => '201', :body => {'features' => [{'name' => 'TFTP'}, {'name' => 'Logs'}], 'unrecognized_features' => []}.to_json)
+      )
+      expect(Puppet).not_to receive(:warning)
+      provider.create
+    end
   end
 
   describe '#destroy' do
@@ -128,6 +144,33 @@
         )
         provider.refresh_features!
       end
+
+      it 'warns about unrecognized features instead of validating' do
+        expect(provider).to receive(:id).and_return(1)
+        expect(provider).to receive(:request).with(:put, 'api/v2/smart_proxies/1/refresh').and_return(
+          double(:code => '200', :body => {'features' => [{'name' => 'TFTP'}], 'unrecognized_features' => ['NewFeature']}.to_json)
+        )
+        expect(Puppet).to receive(:warning).with(/Proxy proxy.example.com has features not recognized by Foreman: NewFeature/)
+        provider.refresh_features!
+      end
+
+      it 'does not warn when unrecognized features list is empty' do
+        expect(provider).to receive(:id).and_return(1)
+        expect(provider).to receive(:request).with(:put, 'api/v2/smart_proxies/1/refresh').and_return(
+          double(:code => '200', :body => {'features' => [{'name' => 'TFTP'}, {'name' => 'Logs'}], 'unrecognized_features' => []}.to_json)
+        )
+        expect(Puppet).not_to receive(:warning)
+        provider.refresh_features!
+      end
+
+      it 'skips feature validation when unrecognized features are present' do
+        expect(provider).to receive(:id).and_return(1)
+        expect(provider).to receive(:request).with(:put, 'api/v2/smart_proxies/1/refresh').and_return(
+          double(:code => '200', :body => {'features' => [{'name' => 'TFTP'}], 'unrecognized_features' => ['Logs']}.to_json)
+        )
+        expect(Puppet).to receive(:warning).with(/Logs/)
+        expect { provider.refresh_features! }.not_to raise_error
+      end
     end
 
     context 'without features in refresh response re-fetches proxy' do
@@ -152,6 +195,18 @@
         )
         expect { provider.refresh_features! }.to raise_error(Puppet::Error, /Proxy proxy.example.com has failed to load one or more features \(Logs\)/)
       end
+
+      it 'warns about unrecognized features after re-fetch' do
+        expect(provider).to receive(:id).and_return(1)
+        expect(provider).to receive(:request).with(:put, 'api/v2/smart_proxies/1/refresh').and_return(
+          double(:code => '200', :body => {}.to_json)
+        )
+        expect(provider).to receive(:request).with(:get, 'api/v2/smart_proxies', :search => 'name="proxy.example.com"').and_return(
+          double('response', :body => {:results => [{:id => 1, :name => 'proxy.example.com', 'features' => [{'name' => 'TFTP'}], 'unrecognized_features' => ['Logs']}]}.to_json, :code => '200')
+        )
+        expect(Puppet).to receive(:warning).with(/Proxy proxy.example.com has features not recognized by Foreman: Logs/)
+        expect { provider.refresh_features! }.not_to raise_error
+      end
     end
   end