untar fdi-image as proxy user/group

To prevent fdi-image files from being chown'd on subsequent puppet agent
runs.

Author: jhoblitt

examples/discovery_images.pp

@@ -0,0 +1,6 @@
+class { 'foreman_proxy':
+  tftp => true,
+}
+class { 'foreman_proxy::plugin::discovery':
+  install_images => true,
+}

manifests/plugin/discovery.pp

@@ -48,6 +48,8 @@
       path    => '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin',
       cwd     => "${tftp_root_clean}/boot",
       creates => "${tftp_root_clean}/boot/fdi-image/initrd0.img",
+      user    => $foreman_proxy::user,
+      group   => $foreman_proxy::group,
     }
   }
 }

spec/acceptance/discovery_spec.rb

@@ -1,13 +1,47 @@
 require 'spec_helper_acceptance'
+require 'json'
+
+shared_examples 'the discovery feature is enabled' do
+  describe command('curl -sk https://127.0.0.1:8443/features') do
+    it { expect(JSON.parse(subject.stdout)).to include('discovery', 'logs') }
+    its(:exit_status) { is_expected.to eq (0) }
+  end
+end
 
 describe 'Scenario: install foreman-proxy with discovery plugin'  do
   before(:context) { purge_foreman_proxy }
 
-  include_examples 'the example', 'discovery.pp'
+  context 'without params' do
+    include_examples 'the example', 'discovery.pp'
+
+    it_behaves_like 'the default foreman proxy application'
+    it_behaves_like 'the discovery feature is enabled'
+  end
+
+  context 'with install_images param' do
+    include_examples 'the example', 'discovery_images.pp'
+
+    it_behaves_like 'the default foreman proxy application'
+    it_behaves_like 'the discovery feature is enabled'
 
-  it_behaves_like 'the default foreman proxy application'
+    %w[
+      /boot/fdi-image-latest.tar
+      /boot/fdi-image/initrd0.img
+      /boot/fdi-image/vmlinuz0
+    ].each do |f|
+      describe file(File.join(tftp_root, f)) do
+        it { is_expected.to be_file }
+        it { is_expected.to be_owned_by 'foreman-proxy' }
+        it { is_expected.to be_grouped_into 'foreman-proxy' }
+        it { is_expected.to be_mode '644' }
+      end
+    end
 
-  describe command('curl -sk https://127.0.0.1:8443/features | grep -q discovery') do
-    its(:exit_status) { should eq 0 }
+    describe file(File.join(tftp_root, '/boot/fdi-image')) do
+      it { is_expected.to be_directory }
+      it { is_expected.to be_owned_by 'foreman-proxy' }
+      it { is_expected.to be_grouped_into 'foreman-proxy' }
+      it { is_expected.to be_mode '755' }
+    end
   end
 end