Skip to content

Commit 8cd6fd1

Browse files
committed
docs: add CHANGES entry for importstats rewrite; ci: add to syntax check
1 parent 42195f3 commit 8cd6fd1

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ jobs:
4848
run: |
4949
perl -c reports/opendmarc-expire
5050
perl -c reports/opendmarc-import
51+
perl -c reports/opendmarc-importstats
5152
perl -c reports/opendmarc-params
5253
perl -c reports/opendmarc-reports
5354

CHANGES-202605.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ CREATE TABLE IF NOT EXISTS suppressions (
127127
- **History file `arc` field values corrected in documentation**: The opendmarc/README documented the `arc` field as `0=pass, 2=fail`; the code has always written `0` (`ARES_RESULT_PASS`) or `7` (`ARES_RESULT_FAIL`). Documentation corrected to match. (#352, issue #214)
128128
- **Duplicate `AUTHRESHDRNAME` macro removed**: `opendmarc-ar.h` defined `AUTHRESHDRNAME` as `"Authentication-Results"`, duplicating the existing `AUTHRESULTSHDR` in `opendmarc.h`. The duplicate was removed and all uses updated to `AUTHRESULTSHDR`. (#357, issue #20)
129129
- **`IgnoreAuthenticatedClients` acceptance now logged**: When the `IgnoreAuthenticatedClients` option causes the milter to immediately accept a message, it previously did so silently. A syslog `INFO` entry is now emitted noting the envelope sender, making it easier to trace why a message bypassed DMARC evaluation. (#387; written by Juri Haberland for openSUSE, submitted by Dirk Stöcker)
130+
- **`opendmarc-importstats` rewritten as a Perl script**: The original 25-line shell script used a hardcoded `/var/tmp/dmarc.dat` path that mismatched the daemon default (`/var/run/opendmarc.dat`) and ran in a world-writable directory. Rewritten as `opendmarc-importstats.in` consistent with every other script in `reports/`. Reads `HistoryFile` from `opendmarc.conf` with a proper parser; `--history-file` overrides on the command line; falls back to `/var/run/opendmarc.dat`. Uses `open(pipe)` instead of shell redirection. (issue #358)
130131

131132
---
132133

0 commit comments

Comments
 (0)