From b6cacf94d55f5b27b05a1d229e52933316afb24d Mon Sep 17 00:00:00 2001 From: Adam Clarke Date: Thu, 18 Mar 2021 16:56:28 +0000 Subject: [PATCH 1/2] Remove hide-library-schemes step to fix Sentry sourcemap upload --- lib/react-native-xcode.sh | 5 ----- 1 file changed, 5 deletions(-) diff --git a/lib/react-native-xcode.sh b/lib/react-native-xcode.sh index 4a4f7a3..2ebb15f 100755 --- a/lib/react-native-xcode.sh +++ b/lib/react-native-xcode.sh @@ -128,11 +128,6 @@ BUNDLE_FILE="$DEST/main.jsbundle" --assets-dest "$DEST" \ $EXTRA_PACKAGER_ARGS -# XCode randomly generates user specific workspace files whenever it feels like it. -# We want these hidden at all times, so go ahead and clean up if they're showing now. -cd "$SCHEMES_MANAGER_DIR/../.." -$NODE_BINARY "$SCHEMES_MANAGER_DIR/index.js" hide-library-schemes - if [[ $DEV != true && ! -f "$BUNDLE_FILE" ]]; then echo "error: File $BUNDLE_FILE does not exist. This must be a bug with" >&2 echo "React Native, please report it here: https://github.com/facebook/react-native/issues" From f79ee5b334dd82dbdfe0eb53a98c54004929bcfc Mon Sep 17 00:00:00 2001 From: Adam Clarke Date: Fri, 19 Mar 2021 14:02:35 +0000 Subject: [PATCH 2/2] Option to skip hide-library-schemes step --- lib/react-native-xcode.sh | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/react-native-xcode.sh b/lib/react-native-xcode.sh index 2ebb15f..f0e6da7 100755 --- a/lib/react-native-xcode.sh +++ b/lib/react-native-xcode.sh @@ -128,6 +128,13 @@ BUNDLE_FILE="$DEST/main.jsbundle" --assets-dest "$DEST" \ $EXTRA_PACKAGER_ARGS +# XCode randomly generates user specific workspace files whenever it feels like it. +# We want these hidden at all times, so go ahead and clean up if they're showing now. +if [[ $SKIP_HIDE_LIB_SCHEMES != true ]]; then + cd "$SCHEMES_MANAGER_DIR/../.." + $NODE_BINARY "$SCHEMES_MANAGER_DIR/index.js" hide-library-schemes +fi + if [[ $DEV != true && ! -f "$BUNDLE_FILE" ]]; then echo "error: File $BUNDLE_FILE does not exist. This must be a bug with" >&2 echo "React Native, please report it here: https://github.com/facebook/react-native/issues"