Skip to content

Commit 9906443

Browse files
authored
Merge pull request #78 from thekid/feature/text-before-images
Add text before images
2 parents 7049c07 + 9cbb7fb commit 9906443

File tree

5 files changed

+34
-20
lines changed

5 files changed

+34
-20
lines changed

src/it/php/de/thekid/dialog/unittest/ServeTest.php

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,19 +44,37 @@ public function serves_favicon() {
4444
#[Test]
4545
public function serves_robots_txt() {
4646
$res= $this->serve('GET', '/robots.txt');
47-
Assert::equals([200, 'text/plain; charset=utf-8'], [$res->status(), $res->headers()['Content-Type']]);
47+
Assert::equals(
48+
[200, 'text/plain; charset=utf-8'],
49+
[$res->status(), $res->headers()['Content-Type']]
50+
);
4851
}
4952

5053
#[Test]
5154
public function serves_homepage() {
5255
$res= $this->serve('GET', '/');
53-
Assert::equals([200, 'text/html; charset=utf-8'], [$res->status(), $res->headers()['Content-Type']]);
56+
Assert::equals(
57+
[200, 'text/html; charset=utf-8'],
58+
[$res->status(), $res->headers()['Content-Type']]
59+
);
60+
}
61+
62+
#[Test]
63+
public function serves_atomfeed() {
64+
$res= $this->serve('GET', '/feed/atom');
65+
Assert::equals(
66+
[200, 'application/atom+xml; charset=utf-8'],
67+
[$res->status(), $res->headers()['Content-Type']]
68+
);
5469
}
5570

5671
#[Test]
5772
public function type_ahead_api_publicly_accessible() {
5873
$res= $this->serve('GET', '/api/suggestions?q=');
59-
Assert::equals([200, 'application/json; charset=utf-8'], [$res->status(), $res->headers()['Content-Type']]);
74+
Assert::equals(
75+
[200, 'application/json; charset=utf-8'],
76+
[$res->status(), $res->headers()['Content-Type']]
77+
);
6078
}
6179

6280
#[Test]

src/main/handlebars/content.handlebars

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,7 @@ parent: feed
3131
<div class="popup"></div>
3232
</div>
3333

34-
<div class="content">
35-
{{& item.content}}
36-
</div>
34+
<div class="content">{{& item.content}}</div>
3735

3836
{{> partials/images in=item style='all'}}
3937
</section>

src/main/handlebars/feed.handlebars

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@
4242
{{> partials/weather in=.}}
4343
</div>
4444

45+
<div class="content">{{& content}}</div>
46+
4547
{{! Content formed of a single video can be played back inline directly }}
4648
{{#if (all (equals 1 (size images)) images.0.is.video)}}
4749
<div class="images is-single">
@@ -71,10 +73,6 @@
7173
</div>
7274
</a>
7375
{{/if}}
74-
75-
<div class="content">
76-
{{& content}}
77-
</div>
7876
</section>
7977
{{/each}}
8078
{{else}}

src/main/handlebars/journey.handlebars

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@ parent: feed
3333
<div class="popup"></div>
3434
</div>
3535

36-
<div class="content">
37-
{{& journey.content}}
38-
</div>
36+
<div class="content">{{& journey.content}}</div>
3937

4038
<ul class="summary">
4139
{{#each itinerary}}
@@ -66,11 +64,10 @@ parent: feed
6664
{{count views '' '(Eine Ansicht)' '(# Ansichten)'}}
6765
{{> partials/weather in=.}}
6866
</div>
69-
{{> partials/images in=.}}
7067

71-
<div class="content">
72-
{{& content}}
73-
</div>
68+
<div class="content">{{& content}}</div>
69+
70+
{{> partials/images in=.}}
7471
</section>
7572
{{/each}}
7673
{{else}}

src/main/handlebars/layout.handlebars

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -538,8 +538,11 @@
538538
overflow: hidden;
539539
540540
&.overview {
541-
grid-template-columns: 1fr 1fr 1fr 1fr;
542-
padding-bottom: 1rem;
541+
grid-template-columns: repeat(4, 1fr);
542+
}
543+
544+
&.is-empty {
545+
display: none;
543546
}
544547
545548
&.all, &.is-single, &.is-preview {
@@ -793,7 +796,7 @@
793796
}
794797
795798
.images.overview {
796-
grid-template-columns: 1fr 1fr;
799+
grid-template-columns: repeat(2, 1fr);
797800
}
798801
799802
.cover h1 {

0 commit comments

Comments
 (0)