Skip to content

Commit f212511

Browse files
committed
clean: Extensions remove_and_replace!
1 parent cdce876 commit f212511

File tree

1 file changed

+18
-6
lines changed

1 file changed

+18
-6
lines changed

Diff for: spec/extensions_spec.rb

+18-6
Original file line numberDiff line numberDiff line change
@@ -196,19 +196,25 @@
196196
end
197197

198198
it 'should be equal remove_and_replace! with []' do
199-
cloned = extensions.clone
200-
expect(extensions.remove_and_replace!([]))
201-
.to eq cloned
199+
expected = extensions.clone
200+
got = extensions.remove_and_replace!([])
201+
202+
expect(got.keys).to eq expected.keys
203+
expect(got[ExtensionType::ECH_OUTER_EXTENSIONS]).to eq nil
204+
expect(extensions.keys - got.keys).to eq []
202205
end
203206

204207
it 'should be equal remove_and_replace! with [key_share]' do
205208
expected = extensions.filter { |k, _| k != ExtensionType::KEY_SHARE }
206209
expected[ExtensionType::ECH_OUTER_EXTENSIONS] = \
207210
Extension::ECHOuterExtensions.new([ExtensionType::KEY_SHARE])
208211
got = extensions.remove_and_replace!([ExtensionType::KEY_SHARE])
212+
209213
expect(got.keys).to eq expected.keys
210214
expect(got[ExtensionType::ECH_OUTER_EXTENSIONS].outer_extensions)
211215
.to eq expected[ExtensionType::ECH_OUTER_EXTENSIONS].outer_extensions
216+
expect(extensions.keys - got.keys)
217+
.to eq expected[ExtensionType::ECH_OUTER_EXTENSIONS].outer_extensions
212218
end
213219

214220
it 'should be equal remove_and_replace! with' \
@@ -223,16 +229,22 @@
223229
extensions.filter { |k, _| outer_extensions.include?(k) }.keys
224230
)
225231
got = extensions.remove_and_replace!(outer_extensions)
232+
226233
expect(got.keys).to eq expected.keys
227234
expect(got[ExtensionType::ECH_OUTER_EXTENSIONS].outer_extensions)
228235
.to eq expected[ExtensionType::ECH_OUTER_EXTENSIONS].outer_extensions
236+
expect(extensions.keys - got.keys)
237+
.to eq expected[ExtensionType::ECH_OUTER_EXTENSIONS].outer_extensions
229238
end
230239

231240
it 'should be equal remove_and_replace! with no key_share extensions' \
232241
' & [key_share]' do
233-
cloned = no_key_share_exs.clone
234-
expect(no_key_share_exs.remove_and_replace!([ExtensionType::KEY_SHARE]))
235-
.to eq cloned
242+
expected = no_key_share_exs.clone
243+
got = no_key_share_exs.remove_and_replace!([ExtensionType::KEY_SHARE])
244+
245+
expect(got).to eq expected
246+
expect(got[ExtensionType::ECH_OUTER_EXTENSIONS]).to eq nil
247+
expect(no_key_share_exs.keys - got.keys).to eq []
236248
end
237249
end
238250
end

0 commit comments

Comments
 (0)