Fix create playlist test and implementation

Author: thelinmichael

CHANGELOG.md

@@ -9,6 +9,7 @@
 * Documentation updates to keep up to date with ES6, thanks [@dandv](https://github.com/dandv)!
 * `reason` added to error object, which is returned by the [Player API](https://developer.spotify.com/documentation/web-api/reference/player/). Much appreciated [@konstantinjdobler](https://github.com/konstantinjdobler)!
 * Binding for [Add an Item to the User's Playback Queue](https://developer.spotify.com/documentation/web-api/reference/player/add-to-queue/) endpoint added. Thanks [@thattomperson](https://github.com/thattomperson) and [@AriciducaZagaria](https://github.com/AriciducaZagaria)!
+* Update the Create Playlist endpoint to avoid using `user_id` as it's no longer necessary. Cheers [@marinacrachi](https://github.com/marinacrachi)!
 
 More coming before NPM release.
 

README.md

@@ -92,6 +92,7 @@ The library includes helper functions to do the following:
 
 #### Player
 
+* Add an Item to the User's Playback Queue
 * Get a user's available devices
 * Get information about the user's current playback
 * Get current user’s recently played tracks
@@ -717,6 +718,9 @@ spotifyApi.getPlaylistsForCategory('party', {
 
 /* Player */
 
+// Add an Item to the User's Playback Queue
+// TBD
+
 // Get a User's Available Devices
 // TBD
 

__tests__/spotify-web-api.js

@@ -1513,7 +1513,7 @@ describe('Spotify Web API', () => {
   });
 
   test('should create a playlist', function(done) {
-    sinon.stub(HttpManager, '_makeRequest', function(
+    sinon.stub(HttpManager, '_makeRequest').callsFake(function(
       method,
       options,
       uri,
@@ -1578,8 +1578,7 @@ describe('Spotify Web API', () => {
 
     api.createPlaylist(
       'My Cool Playlist',
-      { description: 'It\'s really cool' },
-      { public: false },
+      { description: 'It\'s really cool', public: false },
       function(err, data) {
         expect(data.body.name).toBe('My Cool Playlist');
         expect(data.body.description).toBe('It\s really cool');
@@ -1590,8 +1589,8 @@ describe('Spotify Web API', () => {
     );
   });
 
-  test('should create a playlist using callback with user id', done => {
-    sinon.stub(HttpManager, '_makeRequest', function(
+  test('should create a playlist using callback with user id (backward compatability)', done => {
+    sinon.stub(HttpManager, '_makeRequest').callsFake(function(
       method,
       options,
       uri,
@@ -1601,19 +1600,21 @@ describe('Spotify Web API', () => {
       expect(uri).toBe(
         'https://api.spotify.com/v1/me/playlists'
       );
-      expect(JSON.parse(options.data)).toEqual({ name: 'My Cool Playlist' });
-      callback(null, { body: { name: 'My Cool Playlist' }, statusCode: 200 });
+      expect(JSON.parse(options.data)).toEqual({ name: 'My Cool Playlist', public : false });
+      callback(null, { body: { name: 'My Cool Playlist', public: false }, statusCode: 200 });
       expect(options.query).toBeFalsy();
     });
 
     var api = new SpotifyWebApi();
 
-    api.createPlaylist('thelinmichael', 'My Cool Playlist', {}, 
-    function(err, data) {
-      expect(data.body.name).toBe('My Cool Playlist');
-      expect(data.statusCode).toBe(200);
-      done();
-    });
+    api.createPlaylist('thelinmichael', 'My Cool Playlist', { 'public' : false }, 
+      function(err, data) {
+        expect(data.body.name).toBe('My Cool Playlist');
+        expect(data.body.description).toBeFalsy();
+        expect(data.body.public).toBe(false);
+        expect(data.statusCode).toBe(200);
+        done();
+      });
   });
 
   test('should change playlist details', done => {
@@ -1814,7 +1815,7 @@ describe('Spotify Web API', () => {
   });
 
   test("should add songs to the user's queue:", done => {
-    sinon.stub(HttpManager, '_makeRequest', function(
+    sinon.stub(HttpManager, '_makeRequest').callsFake(function(
       method,
       options,
       uri,

src/spotify-web-api.js

@@ -517,16 +517,22 @@ SpotifyWebApi.prototype = {
    */
   createPlaylist: function(name, options, callback) {
     // In case someone is using a version where user id was required
+    var actualOptions = {};
+    var actualCallback = null;
     if (typeof options === 'string') {
-      options = callback;
-      callback = arguments[3];
+      actualOptions = callback || {};
+      actualOptions.name = options;
+      actualCallback = arguments[3];
+    } else {
+      actualOptions = options || {};
+      actualCallback = callback;
+      actualOptions.name = name;
     }
-    options.name = name;
-
+    
     return WebApiRequest.builder(this.getAccessToken())
       .withPath('/v1/me/playlists')
       .withHeaders({ 'Content-Type': 'application/json' })
-      .withBodyParameters(options)
+      .withBodyParameters(actualOptions)
       .build()
       .execute(HttpManager.post, actualCallback);
   },
@@ -1020,7 +1026,6 @@ SpotifyWebApi.prototype = {
   },
 
   /**
-
    * Add track or episode to device queue
    * @param {string} [uri] uri of the track or episode to add
    * @param {Object} [options] Options, being device_id.
@@ -1042,6 +1047,7 @@ SpotifyWebApi.prototype = {
   },
 
 
+  /** 
    * Get the Current User's Available Devices
    * @param {requestCallback} [callback] Optional callback method to be called instead of the promise.
    * @returns {Promise|undefined} A promise that if successful, resolves into an array of device objects,