Skip to content

Commit 3bca71e

Browse files
committed
Merge pull request #7 from liquiddc/master
Pull liquiddc changes in to IE branch
2 parents 039d8f9 + 505521b commit 3bca71e

File tree

6 files changed

+494
-4
lines changed

6 files changed

+494
-4
lines changed

dashing.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
Gem::Specification.new do |s|
44
s.name = 'dashing'
5-
s.version = '1.3.2'
5+
s.version = '1.3.x'
66
s.date = '2013-11-21'
77
s.executables << 'dashing'
88

javascripts/dashing.coffee

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,8 @@ Dashing.debugMode = false
9494

9595
source = new EventSource('/events')
9696
source.addEventListener 'open', (e) ->
97-
console.log("Connection opened", e)
97+
if Dashing.debugMode
98+
console.log("Connection opened", e)
9899

99100
source.addEventListener 'error', (e)->
100101
console.log("Connection error", e)

lib/dashing/app.rb

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,19 @@ def protected!
6767
get '/events', provides: 'text/event-stream' do
6868
protected!
6969
response.headers['X-Accel-Buffering'] = 'no' # Disable buffering for nginx
70+
response.headers['Access-Control-Allow-Origin'] = '*' # For Yaffle eventsource polyfill
71+
response.headers['Cache-Control'] = 'no-cache' # For Yaffle eventsource polyfill
72+
7073
stream :keep_open do |out|
7174
settings.connections << out
75+
76+
# For Yaffle eventsource polyfill
77+
#Add 2k padding for IE
78+
str = ":".ljust(2049) << "\n"
79+
#add retry key
80+
str << "retry: 2000\n"
81+
out << str
82+
7283
out << latest_events
7384
out.callback { settings.connections.delete(out) }
7485
end

templates/project/assets/javascripts/application.coffee

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
1+
# make sure Yaffle's eventsource goes in first
2+
#= require eventsource.js
3+
4+
15
# dashing.js is located in the dashing framework
26
# It includes jquery & batman for you.
37
#= require dashing.js
48

59
#= require_directory .
610
#= require_tree ../../widgets
711

8-
console.log("Yeah! The dashboard has started!")
12+
# console.log("Yeah! The dashboard has started!")
913

1014
Dashing.on 'ready', ->
1115
Dashing.widget_margins ||= [5, 5]

0 commit comments

Comments
 (0)