Skip to content

Commit 81c1d4e

Browse files
RDILRDIL
authored
fix: update yacht assassination challenge categories (#663)
<!-- Thanks for contributing to Peacock! Here's a bit of a template to help make sure everything relevant is covered. --> ## Scope Moved two incorrectly labeled ICA Facility assassination challenges from feats to assassinations. <!-- List any relevant changes you have made here. Be sure to link any issues fixed, or that are relevant to these changes. --> ## Test Plan Tested in WoA, made the assumption that H2 will work the same way. <!-- List how you have verified these changes work as intended. --> ## Checklist <!-- Once you create the PR, the checklist will be added below this comment automatically (based on what files you've changed). It's just a few reminders to make sure everything is perfect. You can place an "X" in the boxes to tick them off. When you have completed the checklist, press the "Ready for review" button. --> -------- #### General - [x] I've run Prettier to format any changed files - [x] I've verified that my changes work, and included a test plan -------- #### Escalations - [x] Any new escalations added follow the [escalation guidelines](https://github.com/thepeacockproject/Peacock/blob/master/docs/ESCALATION_GUIDELINES.md)
2 parents 0599b2b + 0aad180 commit 81c1d4e

2 files changed

Lines changed: 198 additions & 198 deletions

File tree

‎contractdata/FACILITY/_FACILITY_CHALLENGES.json‎

Lines changed: 100 additions & 100 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,106 @@
110110
"ContractIds": ["b573932d-7a34-44f1-bcf4-ea8f79f75710"]
111111
}
112112
},
113+
{
114+
"Id": "57e399bc-e449-4805-bbae-f7cd257925fe",
115+
"Name": "UI_CHALLENGES_PROLOGUE_LIFERAFT_KILL_NAME",
116+
"ImageName": "images/challenges/lat73/prologue_c_liferaft_kill.jpg",
117+
"Description": "UI_CHALLENGES_PROLOGUE_LIFERAFT_KILL_DESC",
118+
"Rewards": {
119+
"MasteryXP": 2000
120+
},
121+
"Drops": [],
122+
"IsPlayable": true,
123+
"IsLocked": false,
124+
"HideProgression": true,
125+
"CategoryName": "UI_MENU_PAGE_PROFILE_CHALLENGES_CATEGORY_SIGNATUREKILL",
126+
"Icon": "challenge_category_assassination",
127+
"LocationId": "LOCATION_PARENT_ICA_FACILITY",
128+
"ParentLocationId": "LOCATION_PARENT_ICA_FACILITY",
129+
"Type": "contract",
130+
"DifficultyLevels": [],
131+
"OrderIndex": 10000,
132+
"XpModifier": {},
133+
"RuntimeType": "Hit",
134+
"Definition": {
135+
"Context": {},
136+
"Scope": "session",
137+
"States": {
138+
"Start": {
139+
"Kill": {
140+
"Condition": {
141+
"$and": [
142+
{
143+
"$eq": ["$Value.IsTarget", true]
144+
},
145+
{
146+
"$eq": [
147+
"$Value.SetPieceType",
148+
"99743df5-fef0-4c20-a1b6-deb34f094a44"
149+
]
150+
}
151+
]
152+
},
153+
"Transition": "Success"
154+
}
155+
}
156+
}
157+
},
158+
"Tags": ["clean", "medium", "assassination"],
159+
"InclusionData": {
160+
"ContractIds": ["b573932d-7a34-44f1-bcf4-ea8f79f75710"]
161+
}
162+
},
163+
{
164+
"Id": "df10cfd0-545e-40db-afca-cf5c178870a5",
165+
"Name": "UI_CHALLENGES_PROLOGUE_TARGET_EXPLOSION_NAME",
166+
"ImageName": "images/challenges/lat73/prologue_c_target_explosion.jpg",
167+
"Description": "UI_CHALLENGES_PROLOGUE_TARGET_EXPLOSION_DESC",
168+
"Rewards": {
169+
"MasteryXP": 1000
170+
},
171+
"Drops": [],
172+
"IsPlayable": true,
173+
"IsLocked": false,
174+
"HideProgression": true,
175+
"CategoryName": "UI_MENU_PAGE_PROFILE_CHALLENGES_CATEGORY_SIGNATUREKILL",
176+
"Icon": "challenge_category_assassination",
177+
"LocationId": "LOCATION_PARENT_ICA_FACILITY",
178+
"ParentLocationId": "LOCATION_PARENT_ICA_FACILITY",
179+
"Type": "contract",
180+
"DifficultyLevels": [],
181+
"OrderIndex": 10000,
182+
"XpModifier": {},
183+
"RuntimeType": "Hit",
184+
"Definition": {
185+
"Context": {},
186+
"Scope": "session",
187+
"States": {
188+
"Start": {
189+
"Kill": {
190+
"Condition": {
191+
"$and": [
192+
{
193+
"$eq": ["$Value.IsTarget", true]
194+
},
195+
{
196+
"$eq": [
197+
"$Value.KillItemRepositoryId",
198+
"7d0c107e-4279-4fda-a7e2-77359271cb9a"
199+
]
200+
}
201+
]
202+
},
203+
"Transition": "Success"
204+
}
205+
}
206+
}
207+
},
208+
"Tags": ["clean", "easy", "assassination"],
209+
"InclusionData": {
210+
"ContractIds": ["b573932d-7a34-44f1-bcf4-ea8f79f75710"]
211+
}
212+
},
113213
{
114214
"Id": "228996e6-5fff-4f76-95de-484ee941c0ab",
115215
"Name": "UI_CHALLENGES_GRADUATION_DEATH_BYPROXY_NAME",
@@ -1128,56 +1228,6 @@
11281228
"ContractIds": ["b573932d-7a34-44f1-bcf4-ea8f79f75710"]
11291229
}
11301230
},
1131-
{
1132-
"Id": "57e399bc-e449-4805-bbae-f7cd257925fe",
1133-
"Name": "UI_CHALLENGES_PROLOGUE_LIFERAFT_KILL_NAME",
1134-
"ImageName": "images/challenges/lat73/prologue_c_liferaft_kill.jpg",
1135-
"Description": "UI_CHALLENGES_PROLOGUE_LIFERAFT_KILL_DESC",
1136-
"Rewards": {
1137-
"MasteryXP": 2000
1138-
},
1139-
"Drops": [],
1140-
"IsPlayable": true,
1141-
"IsLocked": false,
1142-
"HideProgression": true,
1143-
"CategoryName": "UI_MENU_PAGE_PROFILE_CHALLENGES_CATEGORY_COMMUNITY",
1144-
"Icon": "challenge_category_feats",
1145-
"LocationId": "LOCATION_PARENT_ICA_FACILITY",
1146-
"ParentLocationId": "LOCATION_PARENT_ICA_FACILITY",
1147-
"Type": "contract",
1148-
"DifficultyLevels": [],
1149-
"OrderIndex": 10000,
1150-
"XpModifier": {},
1151-
"RuntimeType": "Hit",
1152-
"Definition": {
1153-
"Context": {},
1154-
"Scope": "session",
1155-
"States": {
1156-
"Start": {
1157-
"Kill": {
1158-
"Condition": {
1159-
"$and": [
1160-
{
1161-
"$eq": ["$Value.IsTarget", true]
1162-
},
1163-
{
1164-
"$eq": [
1165-
"$Value.SetPieceType",
1166-
"99743df5-fef0-4c20-a1b6-deb34f094a44"
1167-
]
1168-
}
1169-
]
1170-
},
1171-
"Transition": "Success"
1172-
}
1173-
}
1174-
}
1175-
},
1176-
"Tags": ["clean", "medium", "feats"],
1177-
"InclusionData": {
1178-
"ContractIds": ["b573932d-7a34-44f1-bcf4-ea8f79f75710"]
1179-
}
1180-
},
11811231
{
11821232
"Id": "5c312f4a-5895-42ab-bce7-cd6c166113b1",
11831233
"Name": "UI_CHALLENGES_PROLOGUE_ITEM_FOUND_NAME",
@@ -1459,56 +1509,6 @@
14591509
"ContractIds": ["b573932d-7a34-44f1-bcf4-ea8f79f75710"]
14601510
}
14611511
},
1462-
{
1463-
"Id": "df10cfd0-545e-40db-afca-cf5c178870a5",
1464-
"Name": "UI_CHALLENGES_PROLOGUE_TARGET_EXPLOSION_NAME",
1465-
"ImageName": "images/challenges/lat73/prologue_c_target_explosion.jpg",
1466-
"Description": "UI_CHALLENGES_PROLOGUE_TARGET_EXPLOSION_DESC",
1467-
"Rewards": {
1468-
"MasteryXP": 1000
1469-
},
1470-
"Drops": [],
1471-
"IsPlayable": true,
1472-
"IsLocked": false,
1473-
"HideProgression": true,
1474-
"CategoryName": "UI_MENU_PAGE_PROFILE_CHALLENGES_CATEGORY_COMMUNITY",
1475-
"Icon": "challenge_category_feats",
1476-
"LocationId": "LOCATION_PARENT_ICA_FACILITY",
1477-
"ParentLocationId": "LOCATION_PARENT_ICA_FACILITY",
1478-
"Type": "contract",
1479-
"DifficultyLevels": [],
1480-
"OrderIndex": 10000,
1481-
"XpModifier": {},
1482-
"RuntimeType": "Hit",
1483-
"Definition": {
1484-
"Context": {},
1485-
"Scope": "session",
1486-
"States": {
1487-
"Start": {
1488-
"Kill": {
1489-
"Condition": {
1490-
"$and": [
1491-
{
1492-
"$eq": ["$Value.IsTarget", true]
1493-
},
1494-
{
1495-
"$eq": [
1496-
"$Value.KillItemRepositoryId",
1497-
"7d0c107e-4279-4fda-a7e2-77359271cb9a"
1498-
]
1499-
}
1500-
]
1501-
},
1502-
"Transition": "Success"
1503-
}
1504-
}
1505-
}
1506-
},
1507-
"Tags": ["clean", "easy", "feats"],
1508-
"InclusionData": {
1509-
"ContractIds": ["b573932d-7a34-44f1-bcf4-ea8f79f75710"]
1510-
}
1511-
},
15121512
{
15131513
"Id": "df35b620-ca4d-40f1-ae50-9297585ede5d",
15141514
"Name": "UI_CHALLENGES_PROLOGUE_NORFOLK_MEETING_NAME",

0 commit comments

Comments
 (0)