diff --git a/src/AbstractCsvTest.php b/src/AbstractCsvTest.php
index 8beeb70e..70adcf5a 100644
--- a/src/AbstractCsvTest.php
+++ b/src/AbstractCsvTest.php
@@ -26,7 +26,6 @@
use function ob_get_clean;
use function ob_start;
use function strtolower;
-use function Symfony\Component\VarDumper\Dumper\esc;
use function tempnam;
use function tmpfile;
use function unlink;
@@ -47,7 +46,7 @@ protected function setUp(): void
{
$tmp = new SplTempFileObject();
foreach ($this->expected as $row) {
- $tmp->fputcsv($row, escape: "\\");
+ $tmp->fputcsv($row, escape: '\\');
}
$this->csv = Reader::createFromFileObject($tmp);
diff --git a/src/CallbackStreamFilterTest.php b/src/CallbackStreamFilterTest.php
index bf7bdfb3..cdc5edde 100644
--- a/src/CallbackStreamFilterTest.php
+++ b/src/CallbackStreamFilterTest.php
@@ -114,7 +114,7 @@ public function it_can_be_added_to_a_stream(): void
StreamFilter::appendOnReadTo($stream, 'swap.carrier.return');
StreamFilter::prependOnReadTo($stream, 'toUpper');
$data = [];
- while (($record = fgetcsv($stream, 1000, ',', escape: "\\")) !== false) {
+ while (($record = fgetcsv($stream, 1000, ',', escape: '\\')) !== false) {
$data[] = $record;
}
fclose($stream);
diff --git a/src/XMLConverter.php b/src/XMLConverter.php
index d2eb1a59..6c2e6bd5 100644
--- a/src/XMLConverter.php
+++ b/src/XMLConverter.php
@@ -88,6 +88,7 @@ public function convert(iterable $records): DOMDocument|XMLDocument
*/
public function download(iterable $records, ?string $filename = null, string $encoding = 'utf-8', bool $formatOutput = false): int|false
{
+ /** @var XMLDocument|DOMDocument $document */
$document = $this->convert($records);
if (null !== $filename) {
diff --git a/src/XMLConverterTest.php b/src/XMLConverterTest.php
index da8df583..bc1abc0a 100644
--- a/src/XMLConverterTest.php
+++ b/src/XMLConverterTest.php
@@ -108,16 +108,16 @@ public function testDownload(): void
ob_start();
XMLConverter::create()->fieldElement('cell', 'name')->download([['foo' => 'bar']], 'foobar.xml');
- $output = ob_get_clean();
+ $output = (string) ob_get_clean();
$headers = xdebug_get_headers();
- $xml = ''."\n".'bar |
'."\n";
+ $xml = 'bar |
';
self::assertStringContainsString('content-type: application/xml', strtolower($headers[0]));
self::assertSame('content-transfer-encoding: binary', strtolower($headers[1]));
self::assertSame('content-description: File Transfer', $headers[2]);
self::assertStringContainsString('content-disposition: attachment;filename="foobar.xml"', $headers[3]);
- self::assertSame($xml, $output);
+ self::assertStringContainsString($xml, $output);
}
public function testToXMLWithFormatter(): void