Fixed #1882: Prevent listing directory named 0 from returning unfiltered responses.

Author: frankdejonge

src/AdapterTestUtilities/FilesystemAdapterTestCase.php

@@ -225,6 +225,21 @@ public function writing_a_file_with_an_empty_stream(): void
         });
     }
 
+    /**
+     * @test
+     */
+    public function listing_a_directory_named_0(): void
+    {
+        $this->givenWeHaveAnExistingFile('0/path.txt');
+        $this->givenWeHaveAnExistingFile('1/path.txt');
+
+        $this->runScenario(function () {
+            $listing = iterator_to_array($this->adapter()->listContents('0', false));
+
+            $this->assertCount(1, $listing);
+        });
+    }
+
     /**
      * @test
      */

src/AsyncAwsS3/AsyncAwsS3Adapter.php

@@ -299,7 +299,7 @@ public function listContents(string $path, bool $deep): iterable
     {
         $path = trim($path, '/');
         $prefix = trim($this->prefixer->prefixPath($path), '/');
-        $prefix = empty($prefix) ? '' : $prefix . '/';
+        $prefix = $prefix === '' ? '' : $prefix . '/';
         $options = ['Bucket' => $this->bucket, 'Prefix' => $prefix];
 
         if (false === $deep) {

src/AwsS3V3/AwsS3V3Adapter.php

@@ -375,7 +375,7 @@ public function fileSize(string $path): FileAttributes
     public function listContents(string $path, bool $deep): iterable
     {
         $prefix = trim($this->prefixer->prefixPath($path), '/');
-        $prefix = empty($prefix) ? '' : $prefix . '/';
+        $prefix = $prefix === '' ? '' : $prefix . '/';
         $options = ['Bucket' => $this->bucket, 'Prefix' => $prefix];
 
         if ($deep === false) {

src/GoogleCloudStorage/GoogleCloudStorageAdapter.php

@@ -310,7 +310,7 @@ public function listContents(string $path, bool $deep): iterable
         $prefixedPath = $this->prefixer->prefixPath($path);
         $prefixes = $options = [];
 
-        if ( ! empty($prefixedPath)) {
+        if ($prefixedPath !== '') {
             $options = ['prefix' => sprintf('%s/', rtrim($prefixedPath, '/'))];
         }