Skip to content

Vector bearing returns integer #141

Open
@luppiale

Description

@luppiale

The 2 methods of Vector class returns integer instead of float value.

public function initialBearing()
    {
        Ellipsoid::checkCoordinatesEllipsoid($this->from, $this->to);

        $latA = deg2rad($this->from->getLatitude());
        $latB = deg2rad($this->to->getLatitude());
        $dLng = deg2rad($this->to->getLongitude() - $this->from->getLongitude());

        $y = sin($dLng) * cos($latB);
        $x = cos($latA) * sin($latB) - sin($latA) * cos($latB) * cos($dLng);

        return (float) (rad2deg(atan2($y, $x)) + 360) % 360;
    }

Using % with float variables cast it to integer losing a lot of precision.
If u want an angle between 0 and 360 you can do something like this

$angle = rad2deg(atan2($y, $x)) + 360;
return $angle > 360 ? $angle - 360 : $angle;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions