-
-
Notifications
You must be signed in to change notification settings - Fork 212
Open
Description
Version(s) affected
5.1.1/5.2.x
Description
When using 'use_autolinks' => true
it can fail on cases where link's href and text are encoded differently using:
- HTML encoding (
&
<>&
, etc) - URL encoding (
%xx
sequences)
The strict comparison that autolinks check uses should be softened by converation to a common form.
Also we should probably make that HTML encodings are decoded for markdown output, while URL encodings are left as is, is this right?
How to reproduce
$converter = new HtmlConverter();
$converter->setOptions([ 'use_autolinks' => true ]);
echo $converter->convert('<a href="https://example.com/?a=1&b=foo%2Fbar">https://example.com/?a=1&b=foo/bar</a>');
// [https://example.com/?a=1&b=foo/bar](https://example.com/?a=1&b=foo%2Fbar)
Metadata
Metadata
Assignees
Labels
No labels