Issue with AbstractProvider method parseResponse

[janikaja-tet]

I have an issue with AbstractProvider method parseResponse: GitHub

PHP docs say that the method always returns array, but it's not true.
As you can see the method throws UnexpectedValueException only if it cannot parse JSON response with a correct header or if response status code is 500. In all other cases if JSON response cannot be parsed/decoded, the method returns the original response body that is a string value.
Now if the next method that is called by my code is prepareAccessTokenResponse, then a TypeError exception is thrown, because that method accepts only arrays, and we have a clear contradiction here!

My suggestion is that parseResponse method should always re-throw UnexpectedValueException when it cannot parse/decode the response regardless of the reason (with a different message explaining the reason).

[austin48]

I am seeing a similar issue with a 404 response. the following line in parseResponse(ResponseInterface $response)

$content = (string) $response->getBody();

sets $content to null when the $response is a 404. (Also, the url I'm trying that sends back 404 does not include the Content-Type and Content-Length is 0)

Then when it runs

try { return $this->parseJson($content); }

parseJson($content) doesn't handle the null content, which should have been a Syntax Error, and silently returns null. So my original call to getParsedResponse(RequestInterface $request) also returns null. So I don't know that the request resulted in a 404

[ciaranmcnulty]

I got the same issue with a 400 Forbidden HTML response (from Cloudflare) and a provider that assumes an array return