Removed 'positive' validation for minimum and maximum schema values

Author: Samuel Nogueira

src/Schema/Keywords/Maximum.php

@@ -44,10 +44,10 @@ public function validate($data, $maximum, bool $exclusiveMaximum = false): void
         try {
             if (class_exists(NumericVal::class)) {
                 Validator::numericVal()->assert($data);
-                Validator::numericVal()->positive()->assert($maximum);
+                Validator::numericVal()->assert($maximum);
             } else {
                 Validator::numeric()->assert($data);
-                Validator::numeric()->positive()->assert($maximum);
+                Validator::numeric()->assert($maximum);
             }
         } catch (Exception | ExceptionInterface $e) {
             throw InvalidSchema::becauseDefensiveSchemaValidationFailed($e);

src/Schema/Keywords/Minimum.php

@@ -44,10 +44,10 @@ public function validate($data, $minimum, bool $exclusiveMinimum = false): void
         try {
             if (class_exists(NumericVal::class)) {
                 Validator::numericVal()->assert($data);
-                Validator::numericVal()->positive()->assert($minimum);
+                Validator::numericVal()->assert($minimum);
             } else {
                 Validator::numeric()->assert($data);
-                Validator::numeric()->positive()->assert($minimum);
+                Validator::numeric()->assert($minimum);
             }
         } catch (Exception | ExceptionInterface $e) {
             throw InvalidSchema::becauseDefensiveSchemaValidationFailed($e);

tests/Schema/Keywords/MaximumTest.php

@@ -10,16 +10,20 @@
 
 final class MaximumTest extends SchemaValidatorTest
 {
-    public function testMaximumNonexclusiveKeywordGreen(): void
+    /**
+     * @testWith [100]
+     *           [0]
+     *           [-1]
+     */
+    public function testMaximumNonexclusiveKeywordGreen(int $data): void
     {
         $spec = <<<SPEC
 schema:
   type: number
-  maximum: 100
+  maximum: {$data}
 SPEC;
 
         $schema = $this->loadRawSchema($spec);
-        $data   = 100;
 
         (new SchemaValidator())->validate($data, $schema);
         $this->addToAssertionCount(1);

tests/Schema/Keywords/MinimumTest.php

@@ -10,16 +10,20 @@
 
 final class MinimumTest extends SchemaValidatorTest
 {
-    public function testMinimumNonexclusiveKeywordGreen(): void
+    /**
+     * @testWith [100]
+     *           [0]
+     *           [-1]
+     */
+    public function testMinimumNonexclusiveKeywordGreen(int $data): void
     {
         $spec = <<<SPEC
 schema:
   type: number
-  minimum: 100
+  minimum: {$data}
 SPEC;
 
         $schema = $this->loadRawSchema($spec);
-        $data   = 100;
 
         (new SchemaValidator())->validate($data, $schema);
         $this->addToAssertionCount(1);