Merge pull request #10 from theplant/refactor

molon · web-flow · commit 7cf20f47439a · 2025-08-01T10:16:25.000+08:00
Refactor RetryAfterFrom variable naming and comments
diff --git a/ratelimiter.go b/ratelimiter.go
@@ -96,11 +96,13 @@ func (r *Reservation) RetryAfterFrom(t time.Time) (time.Duration, error) {
 		return 0, errors.New("cannot get retry after from OK reservation")
 	}
 
-	delay := r.TimeToAct.Sub(t) - r.MaxFutureReserve
-	if delay < 0 {
+	// We subtract MaxFutureReserve to calculate the minimum wait time before retrying
+	// with the same ReserveRequest can succeed.
+	retryAfter := r.TimeToAct.Sub(t) - r.MaxFutureReserve
+	if retryAfter < 0 {
 		return 0, nil
 	}
-	return delay, nil
+	return retryAfter, nil
 }
 
 // RetryAfter returns the duration to wait before retrying from now.

Original file line number	Diff line number	Diff line change
`@@ -96,11 +96,13 @@ func (r *Reservation) RetryAfterFrom(t time.Time) (time.Duration, error) {`
`96`	`96`	`return 0, errors.New("cannot get retry after from OK reservation")`
`97`	`97`	`}`
`98`	`98`
`99`		`- delay := r.TimeToAct.Sub(t) - r.MaxFutureReserve`
`100`		`- if delay < 0 {`
	`99`	`+ // We subtract MaxFutureReserve to calculate the minimum wait time before retrying`
	`100`	`+ // with the same ReserveRequest can succeed.`
	`101`	`+ retryAfter := r.TimeToAct.Sub(t) - r.MaxFutureReserve`
	`102`	`+ if retryAfter < 0 {`
`101`	`103`	`return 0, nil`
`102`	`104`	`}`
`103`		`- return delay, nil`
	`105`	`+ return retryAfter, nil`
`104`	`106`	`}`
`105`	`107`
`106`	`108`	`// RetryAfter returns the duration to wait before retrying from now.`