Are all the package dependencies necessary?

[marklam]

The nuget packages reference CommandLineParser, Microsoft.AspNetCore.Mvc.NewtonsoftJson and Microsoft.Extensions.Hosting but they don't seem to be referenced by the assemblies in the packages.

[jim-shofstahl]

The 4 libraries that we supply with RawFileReader don't use Json in them and don't have any references to either System.Text..Json or Newtonsoft.Json. So if the assembly is being loading as a dependency from the NuGet package, then it is being called from one of the external dependencies that RawFileReader uses.

There is one project in the CommonCore project that does using Newtonsoft.Json but it is one of our web based UI classes that isn't called from the 4 assemblies we provide with RawFileReader.

[marklam]

Yes, I think the nuget packages have dependencies that the assemblies don't actually need

If you open ThermoFisher.CommonCore.Data.8.0.6.nupkg (https://github.com/thermofisherlsms/RawFileReader/blob/main/Libs/NetCore/Net8/ThermoFisher.CommonCore.Data.8.0.6.nupkg)
in NuGet Package Explorer you can see the package dependencies, which are listed as:

It also lets you see the metadata as source:

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
  <metadata>
    <id>ThermoFisher.CommonCore.Data</id>
    <version>8.0.6</version>
    <authors>ThermoFisher.CommonCore.Data</authors>
    <owners></owners>
    <requireLicenseAcceptance>false</requireLicenseAcceptance>
    <description>Common data structues and shared logic (shared in common core DLLs)</description>
    <copyright>Copyright © 1998 - 2024  Thermo Fisher Scientific, Inc</copyright>
    <dependencies>
      <group targetFramework="net8.0">
        <dependency id="CommandLineParser" version="2.9.1" exclude="Build,Analyzers" />
        <dependency id="Microsoft.AspNetCore.Mvc.NewtonsoftJson" version="8.0.0" exclude="Build,Analyzers" />
        <dependency id="Microsoft.Extensions.Hosting" version="8.0.0" exclude="Build,Analyzers" />
      </group>
    </dependencies>
  </metadata>
</package>

[FarmGeek4Life]

@jshofstahl I think when somebody added those libraries they accidentally installed them to all projects, because all 5 of the .NET 8.0 .nupkg files list CommandLineParser, Microsoft.AspNetCore.Mvc.NewtonsoftJson, and Microsoft.Extensions.Hosting as dependencies, and it's annoying because those cause a cascade requirement of about 40 other packages:

• CommandLineParser: 0 dependencies on other packages
• Microsoft.AspNetCore.Mvc.NewtonsoftJson: 3 direct package dependencies, 18+ nested ones
• Microsoft.Extensions.Hosting: 22 dependencies on other packages

For my own use I'm probably going to edit the .nupkg files that I have locally stored to remove the unnecessary dependencies, but I would prefer not needing to do so.

[jim-shofstahl]

Thanks for the information. I took a look at the NuGet package files and noticed the dependencies and then had one of our SCM engineers look at the project files. It will be fixed in a future update.