Skip to content

Commit 54cab09

Browse files
committed
ci: fix Ubuntu Bionic job
Do the same as pytorch/test-infra#5959 and download an old nodejs to keep Ubuntu Bionic working. Bug: actions/checkout#1809 Bug: actions/runner#3373
1 parent 8578a99 commit 54cab09

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

.github/workflows/os_comp.yml

+14-9
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,6 @@ on:
2626
- ".github/workflows/os_comp.yml"
2727
- "run*tests.py"
2828

29-
# make GHA actions use node16 which still works with bionic
30-
# See https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
31-
# Unclear how long this will work though
32-
env:
33-
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
34-
3529
permissions:
3630
contents: read
3731

@@ -49,13 +43,24 @@ jobs:
4943
- { name: Gentoo, id: gentoo }
5044
- { name: OpenSUSE, id: opensuse }
5145
- { name: Ubuntu Bionic, id: bionic }
52-
container: mesonbuild/${{ matrix.cfg.id }}:latest
46+
container:
47+
image: mesonbuild/${{ matrix.cfg.id }}:latest
48+
volumes:
49+
- ${{ matrix.cfg.id == 'bionic' && '/node20217:/node20217:rw,rshared' || ' ' }}
50+
- ${{ matrix.cfg.id == 'bionic' && '/node20217:/__e/node20:ro,rshared' || ' ' }}
5351
env:
5452
MESON_CI_JOBNAME: linux-${{ matrix.cfg.id }}-gcc
5553

5654
steps:
57-
# Need v3 because of bionic
58-
- uses: actions/checkout@v3
55+
- name: install nodejs20glibc2.17
56+
if: ${{ matrix.cfg.id == 'bionic' }}
57+
run: |
58+
apt install curl -y
59+
curl -LO https://unofficial-builds.nodejs.org/download/release/v20.9.0/node-v20.9.0-linux-x64-glibc-217.tar.xz
60+
tar -xf node-v20.9.0-linux-x64-glibc-217.tar.xz --strip-components 1 -C /node20217
61+
ldd /__e/node20/bin/node
62+
- uses: actions/checkout@v4
63+
5964
- name: Run tests
6065
# All environment variables are stored inside the docker image in /ci/env_vars.sh
6166
# They are defined in the `env` section in each image.json. CI_ARGS should be set

0 commit comments

Comments
 (0)