Skip to content

Commit 1b7b779

Browse files
Merge pull request #519 from theseus-rs/remove-concurrent-vec
refactor: remove ConcurrentVec
2 parents f4a41e4 + 09387b5 commit 1b7b779

File tree

26 files changed

+1314
-1016
lines changed

26 files changed

+1314
-1016
lines changed

ristretto_classloader/src/concurrent_vec.rs

Lines changed: 0 additions & 454 deletions
This file was deleted.

ristretto_classloader/src/lib.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ mod class;
5959
mod class_loader;
6060
mod class_path;
6161
mod class_path_entry;
62-
mod concurrent_vec;
6362
mod error;
6463
mod field;
6564
mod method;
@@ -72,7 +71,6 @@ pub use class::Class;
7271
pub use class_loader::ClassLoader;
7372
pub use class_path::ClassPath;
7473
pub use class_path_entry::{ClassPathEntry, Manifest, manifest};
75-
pub use concurrent_vec::ConcurrentVec;
7674
pub use error::{Error, Result};
7775
pub use field::Field;
7876
pub use method::Method;

ristretto_classloader/src/object.rs

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -606,13 +606,17 @@ impl TryInto<String> for Object {
606606
let coder = self.value("coder")?.to_int()?;
607607
if coder == 0 {
608608
// Latin-1 encoded string
609-
let bytes = bytes.to_vec()?;
609+
let bytes = bytes
610+
.read()
611+
.map_err(|error| PoisonedLock(error.to_string()))?;
610612
#[expect(clippy::cast_sign_loss)]
611613
let value = bytes.iter().map(|&byte| char::from(byte as u8)).collect();
612614
Ok(value)
613615
} else {
614616
// UTF-16 encoded string
615-
let bytes = bytes.to_vec()?;
617+
let bytes = bytes
618+
.read()
619+
.map_err(|error| PoisonedLock(error.to_string()))?;
616620
#[expect(clippy::cast_sign_loss)]
617621
let code_units = bytes
618622
.chunks(2)
@@ -624,7 +628,9 @@ impl TryInto<String> for Object {
624628
}
625629
}
626630
CharArray(bytes) => {
627-
let bytes = bytes.to_vec()?;
631+
let bytes = bytes
632+
.read()
633+
.map_err(|error| PoisonedLock(error.to_string()))?;
628634
let value =
629635
String::from_utf16(&bytes).map_err(|error| ParseError(error.to_string()))?;
630636
Ok(value)

0 commit comments

Comments
 (0)