refactor: Change RequestMethod parameters to contextual lookup

Author: dormant-user

FileBrowserClient/FileBrowserClient/Utilities/BackgroundLogin.swift

@@ -56,7 +56,7 @@ struct BackgroundLogin {
 
         guard var preparedRequest = baseRequest.prepare(
             pathComponents: ["api", "login"],
-            method: RequestMethod.post,
+            method: .post,
         ) else {
             return loginResponse("Failed to prepare request for: /api/login")
         }

FileBrowserClient/FileBrowserClient/Utilities/Request.swift

@@ -70,7 +70,7 @@ class Request {
     func prepare(
         pathComponents: [String],
         queryItems: [URLQueryItem]? = nil,
-        method: RequestMethod = RequestMethod.get,
+        method: RequestMethod = .get,
         headers: [RequestHeader]? = nil,
         contentType: ContentType = ContentType.json,
         timeout: RequestTimeout = RequestTimeout(request: 3.0, resource: 5.0)

FileBrowserClient/FileBrowserClient/Utilities/Utils.swift

@@ -432,7 +432,7 @@ func getTimeStamp(from date: Date? = nil, as customFormat: String = "MMddyyyy_HH
 func getServerVersion(baseRequest: Request) async -> ServerResponse {
     guard let preparedRequest = baseRequest.prepare(
         pathComponents: ["api", "version"],
-        method: RequestMethod.post
+        method: .post
     ) else {
         return ServerResponse(success: false, text: "Failed to prepare request for: /version")
     }

FileBrowserClient/FileBrowserClient/Views/ContentView.swift

@@ -173,11 +173,9 @@ struct ContentView: View {
 
     private func showOtpFaceID(session: StoredSession?) -> Bool {
         guard transitProtection else {
-            Log.info("Transit protection is disabled")
             return false
         }
         guard session?.otpSecret == nil || session?.otpSecret == "" else {
-            Log.info("otpSecret not stored")
             return false
         }
         return showOtpFaceIDJWT(
@@ -396,7 +394,7 @@ struct ContentView: View {
     func terminator(endpoint: String, success: String, failure: String) async -> Bool {
         if let preparedRequest = baseRequest.prepare(
             pathComponents: ["api", endpoint],
-            method: RequestMethod.post
+            method: .post
         ) {
             do {
                 let (_, response) = try await preparedRequest.session.data(for: preparedRequest.request)
@@ -509,7 +507,7 @@ struct ContentView: View {
             return
         }
 
-        guard var preparedRequest = baseRequest.prepare(pathComponents: ["api", "login"], method: RequestMethod.post) else {
+        guard var preparedRequest = baseRequest.prepare(pathComponents: ["api", "login"], method: .post) else {
             let msg = "Failed to prepare request for: /api/login"
             Log.error("❌ \(msg)")
             errorMessage = msg

FileBrowserClient/FileBrowserClient/Views/FileDetailView.swift

@@ -431,7 +431,7 @@ struct FileDetailView: View {
                 URLQueryItem(name: "override", value: "false"),
                 URLQueryItem(name: "rename", value: "false")
             ],
-            method: RequestMethod.patch
+            method: .patch
         ) else {
             let msg = "Failed to prepare request for: /api/resources/\(fromPath)"
             Log.error("❌ \(msg)")
@@ -466,7 +466,7 @@ struct FileDetailView: View {
     func deleteFile() {
         guard let preparedRequest = baseRequest.prepare(
             pathComponents: ["api", "resources", file.path],
-            method: RequestMethod.delete
+            method: .delete
         ) else {
             let msg = "Failed to prepare request for: /api/resources/\(file.path)"
             Log.error("❌ \(msg)")

FileBrowserClient/FileBrowserClient/Views/FileListView.swift

@@ -2231,7 +2231,7 @@ struct FileListView: View {
 
         guard let preparedRequest = baseRequest.prepare(
             pathComponents: ["api", "users", String(currentSettings.id)],
-            method: RequestMethod.get
+            method: .get
         ) else {
             let msg = "Failed to prepare request for: /api/users/\(currentSettings.id)"
             Log.error("❌ \(msg)")
@@ -2287,7 +2287,7 @@ struct FileListView: View {
 
         guard var preparedRequest = baseRequest.prepare(
             pathComponents: ["api", "users", String(currentSettings.id)],
-            method: RequestMethod.put
+            method: .put
         ) else {
             let msg = "Failed to prepare request for: /api/users/\(currentSettings.id)"
             Log.error("❌ \(msg)")
@@ -2349,7 +2349,7 @@ struct FileListView: View {
         for item in selectedItems {
             guard let preparedRequest = baseRequest.prepare(
                 pathComponents: ["api", "resources", item.path],
-                method: RequestMethod.delete
+                method: .delete
             ) else {
                 let msg = "Failed to prepare request for: /api/resources/\(item.path)"
                 Log.error("❌ \(msg)")
@@ -2390,7 +2390,7 @@ struct FileListView: View {
                 URLQueryItem(name: "override", value: "false"),
                 URLQueryItem(name: "rename", value: "false")
             ],
-            method: RequestMethod.patch
+            method: .patch
         ) else {
             let msg = "Failed to prepare request for: \(item.name)"
             Log.error("❌ \(msg)")
@@ -2472,7 +2472,7 @@ struct FileListView: View {
         Log.info("📄 Creating \(resourceType) at path: \(fullPath)")
         guard let preparedRequest = baseRequest.prepare(
             pathComponents: ["/api/resources\(encodedPath)\(separator)override=false"],
-            method: RequestMethod.post
+            method: .post
         ) else {
             let msg = "Failed to prepare request for: /api/resources/\(fullPath)"
             Log.error("❌ \(msg)")

FileBrowserClient/FileBrowserClient/Views/ShareManagementView.swift

@@ -78,7 +78,7 @@ struct ShareManagementView: View {
         Log.info("Deleting share with hash: \(item.hash)")
         guard let preparedRequest = baseRequest.prepare(
             pathComponents: ["api", "share", item.hash],
-            method: RequestMethod.delete
+            method: .delete
         ) else {
             let msg = "Failed to prepare request for: /api/share/\(item.hash)"
             Log.error("❌ \(msg)")

FileBrowserClient/FileBrowserClient/Views/ShareSheetView.swift

@@ -145,7 +145,7 @@ struct ShareSheetView: View {
         }
         guard let preparedRequest = baseRequest.prepare(
             pathComponents: ["api", "share", hash],
-            method: RequestMethod.delete
+            method: .delete
         ) else {
             let msg = "Failed to prepare request for: /api/share/\(hash)"
             Log.error("❌ \(msg)")
@@ -206,7 +206,7 @@ struct ShareSheetView: View {
                 URLQueryItem(name: "expires", value: String(expiryTime)),
                 URLQueryItem(name: "unit", value: shareDuration)
             ],
-            method: RequestMethod.post
+            method: .post
         ) else {
             let msg = "Failed to prepare request for: /api/share/\(file.path)"
             Log.error("❌ \(msg)")