perf: Set auth header for UI in a conventional way

Author: dormant-user

src/templates/index.html

@@ -563,7 +563,6 @@
         const errorMsg = document.getElementById('loginError');
         const username = document.getElementById('username').value.trim();
         const password = document.getElementById('password').value;
-        const authHeaderValue = username + ',' + password;
 
         btn.disabled = true;
         btn.textContent = 'Authenticating…';
@@ -574,7 +573,7 @@
                 method: 'POST',
                 headers: {
                     'Content-Type': 'application/json',
-                    'Authorization': btoa(authHeaderValue)
+                    'Authorization': 'Basic ' + btoa(username + ':' + password)
                 },
             });
 

src/ui.rs

@@ -71,27 +71,34 @@ pub async fn authenticator(
             return HttpResponse::Unauthorized().finish()
         },
     };
-    let encoded = match auth_header.to_str() {
+    let auth_header = match auth_header.to_str() {
         Ok(header) => header,
         Err(err) => {
             log::warn!("{}", err);
             return HttpResponse::Unauthorized().finish()
         },
     };
+    let encoded = match auth_header.strip_prefix("Basic ") {
+        Some(value) => value,
+        None => {
+            log::warn!("Authorization header missing Basic prefix");
+            return HttpResponse::Unauthorized().finish()
+        },
+    };
     let decoded = match base64_decode(encoded) {
         Ok(decoded_) => decoded_,
         Err(err) => {
             log::warn!("{}", err);
             return HttpResponse::Unauthorized().finish()
         },
     };
-    let auth_header = decoded.split(",").collect::<Vec<&str>>();
-    if auth_header.len() != 2 {
+    let auth_parts = decoded.splitn(2, ':').collect::<Vec<&str>>();
+    if auth_parts.len() != 2 {
         log::warn!("Expected two Authorization headers, received {:?}", auth_header);
         return HttpResponse::Unauthorized().finish();
     }
-    let username = auth_header.first().unwrap().to_string();
-    let password = auth_header.last().unwrap().to_string();
+    let username = auth_parts[0].to_string();
+    let password = auth_parts[1].to_string();
     if username == config.username && password == config.password {
         return HttpResponse::Ok().json(json!({ "apikey": config.apikey }))
     }