Skip to content

Commit 37346bc

Browse files
committed
Fix deprecated cookie message
1 parent 7d45ebe commit 37346bc

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

terrariumWebserver.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def decorator(func):
7878
@functools.wraps(func)
7979
def wrapper(*a, **ka):
8080
# Get user info from auth request, then from cookie or else nothing
81-
user, password = request.auth or request.get_cookie("auth", secret=self.cookie_secret) or (None, None)
81+
user, password = request.auth or json.loads(request.get_cookie("auth", secret=self.cookie_secret) or "[null, null]")
8282

8383
if int(self.engine.settings["always_authenticate"]) != -1 and (
8484
required or terrariumUtils.is_true(self.engine.settings["always_authenticate"])
@@ -107,7 +107,7 @@ def wrapper(*a, **ka):
107107
# Update the cookie timeout so that we are staying logged in as long as we are working on the interface
108108
response.set_cookie(
109109
"auth",
110-
request.get_cookie("auth", secret=self.cookie_secret),
110+
request.get_cookie("auth", secret=self.cookie_secret) or "[null,null]",
111111
secret=self.cookie_secret,
112112
**{"max_age": 3600, "path": "/"},
113113
)
@@ -147,7 +147,7 @@ def unit_variables():
147147

148148
authenticated = False
149149
try:
150-
cookie_data = request.get_cookie("auth", secret=self.cookie_secret)
150+
cookie_data = json.loads(request.get_cookie("auth", secret=self.cookie_secret) or "[null, null]")
151151
if cookie_data is not None:
152152
authenticated = self.engine.authenticate(cookie_data[0], cookie_data[1])
153153
except Exception as ex:
@@ -359,14 +359,14 @@ def url_for(self, name, **kwargs):
359359
return url
360360

361361
def __login(self):
362-
response.set_cookie("auth", request.auth, secret=self.cookie_secret, **{"max_age": 3600, "path": "/"})
362+
response.set_cookie("auth", json.dumps(request.auth), secret=self.cookie_secret, **{"max_age": 3600, "path": "/"})
363363
if request.is_ajax:
364364
return {"location": self.url_for("home"), "message": "User logged in."}
365365

366366
redirect(self.url_for("home"))
367367

368368
def __logout(self):
369-
response.set_cookie("auth", None, secret=self.cookie_secret, **{"max_age": 3600, "path": "/"})
369+
response.set_cookie("auth", "[null,null]", secret=self.cookie_secret, **{"max_age": 3600, "path": "/"})
370370
if request.is_ajax:
371371
return {"location": self.url_for("home"), "message": "User logged out."}
372372

@@ -453,7 +453,7 @@ def listen_for_messages(messages, socket):
453453

454454
# First try (existing) cookie login
455455
try:
456-
cookie_data = request.get_cookie("auth", secret=self.webserver.cookie_secret)
456+
cookie_data = json.loads(request.get_cookie("auth", secret=self.webserver.cookie_secret) or "[null, null]")
457457
if cookie_data is not None:
458458
cookie_authenticated = self.webserver.engine.authenticate(cookie_data[0], cookie_data[1])
459459
except Exception as ex:

0 commit comments

Comments
 (0)