-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
A few changes: 1. Switch from `multiprocessing` to `concurrent.futures` with `ProcessPoolExecutor`. This is just to make the code easier to work with. 2. Perform `check_file()` as results return to the main process, in order to reduce peak memory usage. Previously all parsed files were kept in memory before being checked, leading to massive memory usage. 3. Construct parsers once per process, rather than once per file. Previously parser construction took ~5% of the runtime, this reduces it to a constant amount. Benchmarked on a project with 238 templates. Before: ``` $ time curlylint templates/**/*.html All done! ✨ 🍰 ✨ curlylint templates/**/*.html 352.25s user 3.37s system 999% cpu 35.575 total ``` After: ``` $ time curlylint templates/**/*.html All done! ✨ 🍰 ✨ curlylint templates/**/*.html 324.22s user 2.79s system 995% cpu 32.858 total ``` ~8% of the time saved. The parser remains quite slow, I think it does an unfortunate amount of backtracking.
- Loading branch information
1 parent
b64ec22
commit 670c03d
Showing
2 changed files
with
33 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters