Skip to content

Commit 357dc6c

Browse files
authored
Merge pull request #1962 from samson0v/master
Fixed parsing QoS parameter from config
2 parents 7f6b9b0 + 67b11a2 commit 357dc6c

File tree

2 files changed

+16
-9
lines changed

2 files changed

+16
-9
lines changed

thingsboard_gateway/gateway/tb_gateway_service.py

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ def __init__(self, config_file=None):
186186
self.__connectors_init_start_success = False
187187

188188
connection_logger = logging.getLogger('tb_connection')
189+
self.quality_of_service = self.__config['thingsboard'].get('qos', 1)
189190
self.tb_client = TBClient(self.__config["thingsboard"], self._config_dir, connection_logger)
190191
self.tb_client.register_service_subscription_callback(self.subscribe_to_required_topics)
191192
self.tb_client.connect()
@@ -2214,22 +2215,28 @@ def __check_devices_idle_time(self):
22142215
self.stop_event.wait(check_devices_idle_every_sec)
22152216

22162217
@CountMessage('msgsSentToPlatform')
2217-
def send_telemetry(self, telemetry, quality_of_service=None, wait_for_publish=True):
2218-
return self.tb_client.client.send_telemetry(telemetry, quality_of_service=quality_of_service,
2218+
def send_telemetry(self, telemetry, wait_for_publish=True):
2219+
return self.tb_client.client.send_telemetry(telemetry,
2220+
quality_of_service=self.quality_of_service,
22192221
wait_for_publish=wait_for_publish)
22202222

22212223
@CountMessage('msgsSentToPlatform')
2222-
def gw_send_telemetry(self, device, telemetry, quality_of_service=1):
2223-
return self.tb_client.client.gw_send_telemetry(device, telemetry, quality_of_service=quality_of_service)
2224+
def gw_send_telemetry(self, device, telemetry):
2225+
return self.tb_client.client.gw_send_telemetry(device,
2226+
telemetry,
2227+
quality_of_service=self.quality_of_service)
22242228

22252229
@CountMessage('msgsSentToPlatform')
2226-
def send_attributes(self, attributes, quality_of_service=None, wait_for_publish=True):
2227-
return self.tb_client.client.send_attributes(attributes, quality_of_service=quality_of_service,
2230+
def send_attributes(self, attributes, wait_for_publish=True):
2231+
return self.tb_client.client.send_attributes(attributes,
2232+
quality_of_service=self.quality_of_service,
22282233
wait_for_publish=wait_for_publish)
22292234

22302235
@CountMessage('msgsSentToPlatform')
2231-
def gw_send_attributes(self, device, attributes, quality_of_service=1):
2232-
return self.tb_client.client.gw_send_attributes(device, attributes, quality_of_service=quality_of_service)
2236+
def gw_send_attributes(self, device, attributes):
2237+
return self.tb_client.client.gw_send_attributes(device,
2238+
attributes,
2239+
quality_of_service=self.quality_of_service)
22332240

22342241
# Service RPC methods ----------------
22352242
def ping(self):

thingsboard_gateway/tb_utility/tb_gateway_remote_configurator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ def send_connector_current_configuration(self, connector_configuration: dict):
220220
config_to_send[REPORT_STRATEGY_PARAMETER] = config_to_send['configurationJson'].pop(REPORT_STRATEGY_PARAMETER) # noqa
221221
if config_to_send.get('configurationJson', {}).get(CONFIG_VERSION_PARAMETER) is not None:
222222
config_to_send[CONFIG_VERSION_PARAMETER] = config_to_send['configurationJson'].pop(CONFIG_VERSION_PARAMETER)
223-
self._gateway.send_attributes({connector_configuration['name']: config_to_send}, quality_of_service=1)
223+
self._gateway.send_attributes({connector_configuration['name']: config_to_send})
224224

225225
def _load_connectors_configuration(self):
226226
for (_, connector_list) in self._gateway.connectors_configs.items():

0 commit comments

Comments
 (0)