Merge pull request #178 from thkruz/dev

v1.1.0

Author: thkruz

.env.example

@@ -19,3 +19,13 @@ PUBLIC_USER_API_URL=https://user.keeptrack.space
 # Set to R2 custom domain for production (e.g., https://assets.signalrange.space)
 # This enables serving large audio files from R2 instead of bundling them
 PUBLIC_ASSETS_BASE_URL=
+
+# Developer Menu Whitelist
+# Comma-separated list of Supabase user IDs that can access the dev menu
+# Example: PUBLIC_DEV_USER_IDS=uuid1,uuid2,uuid3
+PUBLIC_DEV_USER_IDS=
+
+# Logging Level
+# Controls minimum log level shown in console: LOG, INFO, WARN, ERROR
+# Default: LOG (shows everything)
+PUBLIC_LOG_LEVEL=LOG

.env.production

@@ -18,4 +18,6 @@ PUBLIC_USER_API_URL=https://user.keeptrack.space
 # Leave empty for local development (uses local files in public/)
 # Set to R2 custom domain for production (e.g., https://assets.signalrange.space)
 # This enables serving large audio files from R2 instead of bundling them
-PUBLIC_ASSETS_BASE_URL=https://assets.signalrange.space
+PUBLIC_ASSETS_BASE_URL=https://assets.signalrange.space
+
+PUBLIC_LOG_LEVEL=WARN

.github/actions/setup-node-project/action.yml

@@ -5,7 +5,7 @@ inputs:
   node-version:
     description: 'Node.js version to use'
     required: false
-    default: '18'
+    default: '22'
 
 runs:
   using: 'composite'

.github/pull_request_template.md

@@ -0,0 +1,7 @@
+## Description
+<!-- Describe your changes -->
+
+## Testing
+
+- [ ] Unit tests pass (`npm test`)
+- [ ] E2E tests pass locally (`npm run test:e2e`)

.github/workflows/build-pipeline.yml

@@ -3,6 +3,14 @@ name: Build Pipeline
 
 on:
   workflow_dispatch:
+  push:
+    branches:
+      - main
+      - develop
+    paths-ignore:
+      - '**.md'
+      - 'docs/**'
+      - 'LICENSE'
   pull_request:
     branches:
       - main
@@ -93,7 +101,8 @@ jobs:
           timezoneLinux: 'America/New_York'
 
       - name: Run Tests with Coverage
-        run: npm test -- --coverage --coverageReporters=text --coverageReporters=lcov --coverageReporters=json-summary
+        run: npm test -- --coverage --coverage.reporter=text --coverage.reporter=lcov
+             --coverage.reporter=json-summary --coverage.reporter=json
 
       - name: Upload Coverage Artifact
         uses: actions/upload-artifact@v4
@@ -121,6 +130,47 @@ jobs:
             echo "Line coverage: ${COVERAGE}%" >> $GITHUB_STEP_SUMMARY
           fi
 
+  e2e-tests:
+    name: E2E Tests
+    needs: [lint, type-check, test, security-audit]
+    if: >-
+      (github.event_name == 'pull_request' &&
+      contains(github.event.pull_request.labels.*.name, 'run-e2e')) ||
+      github.event_name == 'workflow_dispatch'
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v4
+        with:
+          submodules: recursive
+
+      - name: Setup Node Project
+        uses: ./.github/actions/setup-node-project
+
+      - name: Install Playwright Browsers
+        run: npx playwright install --with-deps chromium
+
+      - name: Run E2E Tests
+        id: e2e
+        run: npm run test:e2e
+
+      - name: Upload Playwright Report
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: playwright-report
+          path: playwright-report/
+          retention-days: 7
+
+      - name: E2E Test Summary
+        if: always()
+        run: |
+          echo "### E2E Test Results" >> $GITHUB_STEP_SUMMARY
+          echo "- Status: ${{ steps.e2e.outcome }}" >> $GITHUB_STEP_SUMMARY
+          if [ -d playwright-report ]; then
+            echo "E2E tests completed. See artifact for details." >> $GITHUB_STEP_SUMMARY
+          fi
+
   security-audit:
     name: Security Audit
     runs-on: ubuntu-latest
@@ -213,16 +263,16 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@v3
+        uses: github/codeql-action/init@v4
         with:
           languages: javascript-typescript
           queries: security-extended
 
       - name: Autobuild
-        uses: github/codeql-action/autobuild@v3
+        uses: github/codeql-action/autobuild@v4
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@v3
+        uses: github/codeql-action/analyze@v4
         with:
           category: '/language:javascript-typescript'
 

.github/workflows/e2e-attestation.yml

@@ -0,0 +1,42 @@
+---
+name: E2E Attestation
+
+on:
+  pull_request:
+    types: [opened, synchronize, reopened, edited]
+    branches:
+      - main
+      - develop
+
+permissions:
+  contents: read
+  pull-requests: read
+
+jobs:
+  e2e-attestation:
+    name: E2E Attestation
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check E2E Attestation
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const body = context.payload.pull_request.body || '';
+            const pattern = /- \[x\]\s+E2E tests pass locally/i;
+
+            if (!pattern.test(body)) {
+              core.setFailed(
+                'E2E attestation required: Please check the box in the PR description ' +
+                'confirming you have run E2E tests locally and they pass.\n\n' +
+                'Add this to your PR description:\n' +
+                '- [x] E2E tests pass locally (`npm run test:e2e`)'
+              );
+              return;
+            }
+
+            core.info('E2E attestation confirmed.');
+
+            await core.summary
+              .addHeading('E2E Attestation', 3)
+              .addRaw('Developer has attested that E2E tests were run locally and pass.')
+              .write();

.gitignore

@@ -30,6 +30,12 @@ yarn-error.log*
 coverage/
 .nyc_output/
 
+# Playwright
+/test-results/
+/playwright-report/
+/blob-report/
+/playwright/.cache/
+
 # Temporary files
 tmp/
 temp/
@@ -38,6 +44,7 @@ supabase/
 # Notes
 *.notes.*
 notes
+.archive
 
 # Unused Icons
 src/assets/icons/wip

.vscode/settings.json

@@ -35,7 +35,10 @@
   },
   "github.copilot.chat.commitMessageGeneration.instructions": [
     {
-      "text": "Format: <type>: :emoji: <description>"
+      "text": "Format: <type>(<scope>): :emoji: <description>"
+    },
+    {
+      "text": "<scope> is optional and can be omitted if not needed"
     },
     {
       "text": "ALWAYS include the emoji - this is required"

CLAUDE.md

@@ -151,6 +151,35 @@ new Satellite(
   - Example: Uplink at 5943 MHz with `frequencyOffset: 2.225e9` → Downlink at 3718 MHz
 - **Don't duplicate**: If a signal is in the uplink array, the transponder creates the downlink automatically. Don't add it to both arrays.
 
+## TypeScript Type Checking
+
+**Always use the npm script to check for TypeScript errors:**
+
+```bash
+npm run type-check
+```
+
+**Do NOT run tsc directly on individual files:**
+
+```bash
+# WRONG - will fail with module resolution errors
+npx tsc --noEmit src/campaigns/nats/scenario5.ts
+```
+
+This project uses `@app/*` path aliases (e.g., `@app/types`, `@app/equipment/...`) that require the full tsconfig.json configuration. Running tsc on individual files bypasses this and produces false "Cannot find module" errors.
+
+## Git Commits
+
+- Do NOT add `Co-Authored-By` lines to commit messages
+- Use conventional commit format: `type(scope): description`
+- Use emoji in commit titles for clarity:
+  - Example: feat: :sparkles: Add new frequency adjustment control
+  - ✨ `:sparkles:` for new features
+  - 🐛 `:bug:` for bug fixes
+  - ♻️ `:recycle:` for refactoring
+  - 📝 `:memo:` for documentation changes
+- Common types: `feat`, `fix`, `refactor`, `test`, `docs`, `chore`
+
 ## Planning
 
 When you use Plan Mode or create multi-step plans in this repo: