Skip to content

Commit 11931fe

Browse files
committed
Fixed: Random Mix x8 (RX8) not working in trigger mode.
1 parent 175929f commit 11931fe

3 files changed

Lines changed: 11 additions & 8 deletions

File tree

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ Thomas René Sidor
3939

4040

4141
## Changelog
42+
Version 1.2.1
43+
* Fixed: Random Mix x8 (RX8) not working in trigger mode.
44+
4245
Version 1.2.0
4346
* Added: Random Mix x8 (RX8)
4447
* Added: Simplex Noise (SN1)

plugin.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"slug": "TinyTricks",
33
"name": "Tiny Tricks",
44
"brand": "Tiny Tricks",
5-
"version": "1.2.0",
5+
"version": "1.2.1",
66
"license": "MIT",
77
"author": "Thomas René Sidor",
88
"authorEmail": "mail@thomassidor.com",

src/random-mix.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,9 @@ struct RX8Base : Module {
6161

6262

6363
float t = 0.f;
64+
float summedLevels = 0.f;
6465
void process(const ProcessArgs &args) override {
65-
6666
bool freeflow = (params[TRIGONLY_PARAM].getValue() == 0.f);
67-
int connected = 0;
68-
float summedLevels = 0.f;
6967
t += 1.0f / args.sampleRate;
7068

7169
if(freeflow || (inputs[TRIG_INPUT].isConnected() && trigger.process(inputs[TRIG_INPUT].getVoltage()))){
@@ -90,12 +88,11 @@ struct RX8Base : Module {
9088
}
9189

9290
//Getting new levels
93-
float x = t;
91+
summedLevels = 0.f;
9492
for (int i = 0; i < NUM_CHANNELS; i++) {
9593
if(inputs[AUDIO_L_INPUT + i].isConnected()){
96-
connected++;
9794
float y = (2.f*i);
98-
float noiseVal = simp.SumOctave(jitter,x,y,0.7f,speed);
95+
float noiseVal = simp.SumOctave(jitter,t,y,0.7f,speed);
9996
float level = clamp(noiseVal*(pinning),-1.f,1.f);
10097
level *= level;
10198
summedLevels += level;
@@ -108,10 +105,13 @@ struct RX8Base : Module {
108105

109106
//Mixing signal for output
110107
float mix = 0.f;
108+
int connected = 0;
111109
if(outputs[MIX_L_OUTPUT].isConnected()){
112110
for (int i = 0; i < NUM_CHANNELS; i++) {
113-
if(inputs[AUDIO_L_INPUT + i].isConnected())
111+
if(inputs[AUDIO_L_INPUT + i].isConnected()) {
112+
connected++;
114113
mix += inputs[AUDIO_L_INPUT + i].getVoltage()*levels[i];
114+
}
115115
}
116116
if(connected==1)
117117
outputs[MIX_L_OUTPUT].setVoltage(mix);

0 commit comments

Comments
 (0)