Fixed an invalid input handle for DateTimeConverter

Author: thombashi

test/test_type.py

@@ -91,6 +91,27 @@ def test_normal_date(self, value, expected):
 
         assert result == expected
 
+    @pytest.mark.parametrize(
+        ["value"],
+        [
+            [{"1"}],
+            [{"1", "2"}],
+            [["1"]],
+            [["1", "2"]],
+            [{"a": 1}],
+            [(1, 2)],
+            [None],
+        ],
+    )
+    def test_abnormal_non_string(self, value):
+        from typepy.error import TypeConversionError
+
+        with pytest.raises(TypeConversionError):
+            typepy.DateTime({"1"}, strict_level=StrictLevel.MIN).convert()
+
+        assert typepy.DateTime(value, strict_level=StrictLevel.MIN).is_type() is False
+        assert typepy.DateTime(value, strict_level=StrictLevel.MIN).try_convert() is None
+
 
 class Test_IpAddress:
     @pytest.mark.parametrize(

typepy/converter/_datetime.py

@@ -148,13 +148,16 @@ def __validate_datetime_string(self):
 
         from packaging.version import InvalidVersion, Version
 
+        if not isinstance(self._value, str):
+            raise TypeConversionError(
+                f"invalid datetime string: type={type(self._value)}"
+            )
+
         try:
-            try:
-                Version(self._value)
-                raise TypeConversionError(
-                    f"invalid datetime string: version string found {self._value}"
-                )
-            except InvalidVersion:
-                pass
-        except TypeError:
-            raise TypeConversionError(f"invalid datetime string: type={type(self._value)}")
+            Version(self._value)
+        except InvalidVersion:
+            return
+
+        raise TypeConversionError(
+            f"invalid datetime string: version string found {self._value}"
+        )