Update windows workflow to build ARM64 (Xilinx#9620)

Include work-around arm compiler optimization bug, aggresive
optimization fails to see that code is in fact reachable.

Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com>

Author: stsoe

.github/workflows/build-windows.yml

@@ -17,7 +17,20 @@ env:
 
 jobs:
   build-windows:
-    runs-on: windows-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - runner: windows-latest
+            triplet: x64-windows
+            cmake_arch: x64
+            build_dir: WRelease
+          - runner: windows-11-arm
+            triplet: arm64-windows
+            cmake_arch: ARM64
+            build_dir: WRelease-arm64
+
+    runs-on: ${{ matrix.runner }}
 
     steps:
       - name: Checkout repository
@@ -50,30 +63,32 @@ jobs:
             ${{ github.workspace }}/vcpkg/installed
             ${{ github.workspace }}/vcpkg/buildtrees
             ${{ github.workspace }}/vcpkg/downloads
-          key: vcpkg-win-${{ runner.os }}-${{ hashFiles('src/vcpkg.json') }}
+          key: vcpkg-win-${{ matrix.runner }}-${{ matrix.triplet }}-${{ hashFiles('src/vcpkg.json') }}
           restore-keys: |
-            vcpkg-win-${{ runner.os }}-
+            vcpkg-win-${{ matrix.runner }}-${{ matrix.triplet }}-
 
       - name: Install vcpkg dependencies (manifest)
         run: |
-          .\vcpkg\vcpkg.exe install --x-manifest-root="${{ github.workspace }}\src" --triplet=x64-windows
+          .\vcpkg\vcpkg.exe install --x-manifest-root="${{ github.workspace }}\src" --triplet=${{ matrix.triplet }}
         working-directory: ${{ github.workspace }}
 
       - name: Configure CMake (Release)
         run: |
           # github.workspace expands with backslashes on Windows; normalize to forward slashes for CMake
           $ws = "${{ github.workspace }}" -replace '\\', '/'
           $vcpkgRoot = "$ws/vcpkg"
-          $triplet = "x64-windows"
+          $triplet = "${{ matrix.triplet }}"
+          $buildDir = "${{ matrix.build_dir }}"
           # vcpkg toolchain (manifest mode) installs to build/vcpkg_installed/<triplet>; OpenCL.dll is there
-          $kronos = "$ws/build/WRelease/vcpkg_installed/$triplet"
+          $kronos = "$ws/build/$buildDir/vcpkg_installed/$triplet"
           $src = "$ws/src"
-          $build = "$ws/build/WRelease"
+          $build = "$ws/build/$buildDir"
           New-Item -ItemType Directory -Force -Path $build
+          # Pass triplet as literal so vcpkg subprocess does not re-interpret $triplet
           cmake -B $build -S $src `
-            -G "Visual Studio 17 2022" -A x64 `
+            -G "Visual Studio 17 2022" -A ${{ matrix.cmake_arch }} `
             -DCMAKE_TOOLCHAIN_FILE="$vcpkgRoot/scripts/buildsystems/vcpkg.cmake" `
-            -DVCPKG_TARGET_TRIPLET=x64-windows `
+            -DVCPKG_TARGET_TRIPLET=${{ matrix.triplet }} `
             -DKHRONOS="$kronos" `
             -DCMAKE_EXPORT_COMPILE_COMMANDS=ON `
             -DMSVC_PARALLEL_JOBS=4
@@ -82,21 +97,21 @@ jobs:
       - name: Build (Release)
         run: |
           $ws = "${{ github.workspace }}" -replace '\\', '/'
-          $build = "$ws/build/WRelease"
+          $build = "$ws/build/${{ matrix.build_dir }}"
           cmake --build $build --config Release --verbose
         shell: pwsh
 
       - name: Install (staging)
         run: |
           $ws = "${{ github.workspace }}" -replace '\\', '/'
-          $build = "$ws/build/WRelease"
-          $prefix = "$ws/build/WRelease/xilinx/xrt"
+          $build = "$ws/build/${{ matrix.build_dir }}"
+          $prefix = "$build/xilinx/xrt"
           cmake --install $build --config Release --prefix $prefix --verbose
         shell: pwsh
 
       - name: Upload build artifacts
         uses: actions/upload-artifact@v4
         with:
-          name: xrt-windows-Release
-          path: ${{ github.workspace }}/build/WRelease/xilinx/xrt
+          name: xrt-windows-${{ matrix.triplet }}-Release
+          path: ${{ github.workspace }}/build/${{ matrix.build_dir }}/xilinx/xrt
           retention-days: 7

src/runtime_src/core/common/api/xrt_bo.cpp

@@ -1914,6 +1914,10 @@ xrtBOExport(xrtBufferHandle bhdl)
 xrtBufferHandle
 xrtBOAllocFromXcl(xrtDeviceHandle dhdl, xclBufferHandle xhdl)
 {
+#ifdef _MSC_VER
+# pragma warning(push)
+# pragma warning(disable : 4702)  // unreachable code (false positive on ARM64)
+#endif
   try {
     return xdp::native::profiling_wrapper(__func__, [dhdl, xhdl] {
       auto boh = alloc_xbuf(xrt_to_core_device(dhdl), xcl_buffer_handle{xhdl});
@@ -1930,6 +1934,9 @@ xrtBOAllocFromXcl(xrtDeviceHandle dhdl, xclBufferHandle xhdl)
     send_exception_message(ex.what());
   }
   return nullptr;
+#ifdef _MSC_VER
+# pragma warning(pop)
+#endif
 }
 
 int