Merge pull request #43 from lepidus/main

fix/prevents registration of publications without related files (OMP 3.4.0)

Author: thiagolepidus

classes/api/ThothEndpoint.inc.php

@@ -99,6 +99,7 @@ public function register($slimRequest, $response, $args)
         try {
             $thothBookService = ThothService::book();
             $thothBookId = $thothBookService->register($publication, $thothImprintId);
+            $thothBookService->setActive();
             Repo::submission()->edit($submission, ['thothWorkId' => $thothBookId]);
             $this->handleNotification($request, $submission, true, $disableNotification);
         } catch (QueryException $e) {

classes/listeners/PublicationPublishListener.inc.php

@@ -59,6 +59,7 @@ public function registerThothBook($hookName, $args)
         try {
             $thothBookService = ThothService::book();
             $thothBookId = $thothBookService->register($publication, $thothImprintId);
+            $thothBookService->setActive();
             Repo::submission()->edit($submission, ['thothWorkId' => $thothBookId]);
             $thothNotification->notifySuccess($request, $submission);
         } catch (QueryException $e) {

classes/services/ThothBookService.inc.php

@@ -15,6 +15,7 @@
  */
 
 use PKP\db\DAORegistry;
+use ThothApi\GraphQL\Models\Work as ThothWork;
 
 import('plugins.generic.thoth.classes.facades.ThothService');
 import('lib.pkp.classes.services.PKPSchemaService');
@@ -23,6 +24,8 @@ class ThothBookService
 {
     public $factory;
     public $repository;
+
+    private $originalThothBook;
     private $registeredEntryId;
 
     public function __construct($factory, $repository)
@@ -31,6 +34,16 @@ public function __construct($factory, $repository)
         $this->repository = $repository;
     }
 
+    public function getOriginalThothBook()
+    {
+        return $this->originalThothBook;
+    }
+
+    public function setOriginalThothBook($originalThothBook)
+    {
+        $this->originalThothBook = $originalThothBook;
+    }
+
     public function getRegisteredEntryId()
     {
         return $this->registeredEntryId;
@@ -46,6 +59,11 @@ public function register($publication, $thothImprintId)
         $thothBook = $this->factory->createFromPublication($publication);
         $thothBook->setImprintId($thothImprintId);
 
+        if ($thothBook->getWorkStatus() === ThothWork::WORK_STATUS_ACTIVE) {
+            $this->setOriginalThothBook($thothBook);
+            $thothBook->setWorkStatus(ThothWork::WORK_STATUS_FORTHCOMING);
+        }
+
         $thothBookId = $this->repository->add($thothBook);
         $publication->setData('thothBookId', $thothBookId);
         $this->setRegisteredEntryId($thothBookId);
@@ -122,4 +140,16 @@ public function deleteRegisteredEntry()
         $this->repository->delete($this->getRegisteredEntryId());
         $this->setRegisteredEntryId(null);
     }
+
+    public function setActive()
+    {
+        if ($this->getOriginalThothBook() === null) {
+            return;
+        }
+
+        $thothBook = $this->getOriginalThothBook();
+        $thothBook->setWorkId($this->getRegisteredEntryId());
+        $thothBook->setWorkStatus(ThothWork::WORK_STATUS_ACTIVE);
+        $this->repository->edit($thothBook);
+    }
 }

classes/services/ThothLocationService.inc.php

@@ -14,6 +14,7 @@
  * @brief Helper class that encapsulates business logic for Thoth locations
  */
 
+use APP\core\Application;
 use APP\facades\Repo;
 
 class ThothLocationService

classes/services/ThothPublicationService.inc.php

@@ -14,6 +14,7 @@
  * @brief Helper class that encapsulates business logic for Thoth publications
  */
 
+use APP\core\Application;
 use APP\facades\Repo;
 use Biblys\Isbn\Isbn;
 use Biblys\Isbn\IsbnParsingException;
@@ -54,6 +55,10 @@ public function registerByPublication($publication)
         $publicationFormats = DAORegistry::getDAO('PublicationFormatDAO')
             ->getByPublicationId($publication->getId());
         foreach ($publicationFormats as $publicationFormat) {
+            if (!$this->canRegister($publicationFormat)) {
+                continue;
+            }
+
             $this->register($publicationFormat, $thothBookId);
         }
     }
@@ -108,4 +113,26 @@ public function validate($publicationFormat)
 
         return $errors;
     }
+
+    public function canRegister($publicationFormat)
+    {
+        if ($publicationFormat->getPhysicalFormat()) {
+            return true;
+        }
+
+        $submissionFiles = array_filter(
+            iterator_to_array(Repo::submissionFile()
+                ->getCollector()
+                ->filterByAssoc(
+                    Application::ASSOC_TYPE_PUBLICATION_FORMAT,
+                    [$publicationFormat->getId()]
+                )
+                ->getMany()),
+            function ($submissionFile) {
+                return $submissionFile->getData('chapterId') == null;
+            }
+        );
+
+        return count($submissionFiles) > 0 || !empty($publicationFormat->getRemoteUrl());
+    }
 }

version.xml

@@ -3,8 +3,8 @@
 <version>
 	<application>thoth</application>
 	<type>plugins.generic</type>
-	<release>0.2.8.2</release>
-	<date>2025-06-16</date>
+	<release>0.2.8.3</release>
+	<date>2025-08-05</date>
 	<lazy-load>1</lazy-load>
 	<class>ThothPlugin</class>
 </version>