fix: remove redundant aws_default_region argument

Author: noahlevi

src/bin/arguments/mod.rs

@@ -154,15 +154,6 @@ pub fn aws_region() -> Arg {
         .num_args(1)
 }
 
-pub fn aws_default_region() -> Arg {
-    Arg::new("aws-default-region")
-        .long("aws-default-region")
-        .value_name("AWS_DEFAULT_REGION")
-        .env("AWS_DEFAULT_REGION")
-        .help("AWS default region for S3/CloudFront")
-        .num_args(1)
-}
-
 pub fn session() -> Arg {
     Arg::new("duration")
         .short('s')

src/bin/commands/mod.rs

@@ -28,7 +28,6 @@ lazy_static! {
         .arg(arguments::domain())
         .arg(arguments::session())
         .arg(arguments::aws_region())
-        .arg(arguments::aws_default_region())
         .arg(arguments::key());
 }
 

src/bin/commands/start.rs

@@ -22,8 +22,7 @@ lazy_static! {
                 .arg(arguments::session())
                 .arg(arguments::aws_access_key_id())
                 .arg(arguments::aws_secret_access_key())
-                .arg(arguments::aws_region())
-                .arg(arguments::aws_default_region()),
+                .arg(arguments::aws_region()),
         )
         .subcommand(
             Command::new("export-api")
@@ -58,7 +57,7 @@ pub fn graphql_api(arguments: &ArgMatches) -> ThothResult<()> {
         .to_owned();
     let aws_region = arguments
         .get_one::<String>("aws-region")
-        .unwrap_or_else(|| arguments.get_one::<String>("aws-default-region").unwrap())
+        .unwrap()
         .to_owned();
 
     api_server(