Skip to content

Please plugins don't work when using BuildFileName #2721

Open
@cbwl

Description

@cbwl

I've recently begun trying to use the go-rules plugin in place of the built-in go rules as the direction of travel seems to be that the built-in rules will get replaced with the plugin model in future (correct me if I'm wrong!).

There seems to be an issue using plugins when a project is configured to use a different BuildFileName; in my repo we are using BuildFileName = BUILD.plz, and when I add the plugin and the subinclude("///go//build_defs:go") to my build file, I get the following error while building:

❯ plz build //third_party/go:all

Build stopped after 1.1s. 1 target failed:
    ///go//build_defs:go
//third_party/go:all depends on ///go//build_defs:go, but there's no BUILD.plz file in plz-out/subrepos/please/plugins/go/build_defs/

I think, based on the .plzconfig of the plugin, that this should really be looking for a BUILD file within the subrepo, not a BUILD.plz file.

This looks to be a duplicate of #1436, but I don't know that there was any resolution when it was raised there.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions