Skip to content

Commit 83109a5

Browse files
Run Cucumber feature tests on CI (#530)
* Run Cucumber feature tests The CI builds are just too fast. We're only running RSpec and Minitest there, skipping the much slower Cucumber feature tests. This has happened because we broke the RSpec and Minitest runs into two different CI steps, forgetting Cucumber was there. This commit re-adds Cucumber as a separate step, alongside some needed changes.
1 parent b2047c1 commit 83109a5

9 files changed

+29
-14
lines changed

.github/workflows/build.yml

+2
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ jobs:
3535
run: bundle exec rake spec
3636
- name: Minitest tests
3737
run: bundle exec rake test
38+
- name: Cucumber tests
39+
run: bundle exec rake cucumber
3840

3941
standard:
4042
name: Run standard

.tool-versions

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
ruby 3.4.1

Appraisals

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
appraise "rails6.1" do
2+
gem "bigdecimal"
23
gem "byebug"
34
gem "concurrent-ruby", "< 1.3.5"
45
gem "drb"
@@ -11,6 +12,7 @@ appraise "rails6.1" do
1112
end
1213

1314
appraise "rails7.0" do
15+
gem "bigdecimal"
1416
gem "byebug"
1517
gem "concurrent-ruby", "< 1.3.5"
1618
gem "drb"

features/support/rails_template

+6-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
1-
if Rails.gem_version < Gem::Version.new('6')
2-
gsub_file "Gemfile", /^gem 'sqlite3'$/, 'gem "sqlite3", "~> 1.3.6"'
1+
if Rails.gem_version < Gem::Version.new('7.1')
2+
append_to_file("Gemfile", %(gem "bigdecimal"\n))
3+
append_to_file("Gemfile", %(gem "logger"\n))
4+
append_to_file("Gemfile", %(gem "mutex_m"\n))
5+
append_to_file("Gemfile", %(gem "drb"\n))
6+
append_to_file("Gemfile", %(gem "concurrent-ruby", "< 1.3.5"\n))
37
end
48

59
gsub_file "Gemfile", /^ gem 'spring'$/, ' gem "spring", "!= 2.1.1"'

gemfiles/rails6.1.gemfile

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ gem "cucumber"
88
gem "rake"
99
gem "rspec-rails"
1010
gem "standard"
11+
gem "bigdecimal"
1112
gem "byebug"
1213
gem "concurrent-ruby", "< 1.3.5"
1314
gem "drb"

gemfiles/rails7.0.gemfile

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ gem "cucumber"
88
gem "rake"
99
gem "rspec-rails"
1010
gem "standard"
11+
gem "bigdecimal"
1112
gem "byebug"
1213
gem "concurrent-ruby", "< 1.3.5"
1314
gem "drb"

gemfiles/rails7.1.gemfile

+5-4
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,17 @@ source "https://rubygems.org"
44

55
gem "appraisal"
66
gem "aruba"
7-
gem "cucumber"
8-
gem "rake"
9-
gem "rspec-rails"
10-
gem "standard"
117
gem "byebug"
8+
gem "cucumber"
9+
gem "error_highlight"
1210
gem "listen", "~> 3.2"
1311
gem "puma", "~> 6.0"
1412
gem "rails", "~> 7.1.0"
13+
gem "rake"
14+
gem "rspec-rails"
1515
gem "spring", "!= 2.1.1"
1616
gem "spring-watcher-listen", "~> 2.0.0"
1717
gem "sqlite3", "~> 1.4"
18+
gem "standard"
1819

1920
gemspec name: "factory_bot_rails", path: "../"

gemfiles/rails7.2.gemfile

+6-4
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,18 @@ source "https://rubygems.org"
44

55
gem "appraisal"
66
gem "aruba"
7-
gem "cucumber"
8-
gem "rake"
9-
gem "rspec-rails"
10-
gem "standard"
7+
gem "brakeman"
118
gem "byebug"
9+
gem "cucumber"
1210
gem "listen", "~> 3.2"
1311
gem "puma", "~> 6.0"
1412
gem "rails", "~> 7.2.0"
13+
gem "rake"
14+
gem "rspec-rails"
15+
gem "rubocop-rails-omakase"
1516
gem "spring", "!= 2.1.1"
1617
gem "spring-watcher-listen", "~> 2.0.0"
1718
gem "sqlite3", "~> 1.4"
19+
gem "standard"
1820

1921
gemspec name: "factory_bot_rails", path: "../"

gemfiles/rails8.0.gemfile

+5-4
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,22 @@ source "https://rubygems.org"
44

55
gem "appraisal"
66
gem "aruba"
7-
gem "cucumber"
8-
gem "rake"
9-
gem "rspec-rails"
10-
gem "standard"
117
gem "brakeman"
128
gem "byebug"
9+
gem "cucumber"
1310
gem "kamal"
1411
gem "listen", "~> 3.2"
1512
gem "puma", "~> 6.0"
1613
gem "rails", "~> 8.0.0"
14+
gem "rake"
15+
gem "rspec-rails"
1716
gem "rubocop-rails-omakase"
17+
gem "solid_cache"
1818
gem "solid_queue"
1919
gem "spring", "!= 2.1.1"
2020
gem "spring-watcher-listen", "~> 2.0.0"
2121
gem "sqlite3", ">= 2.1"
22+
gem "standard"
2223
gem "thruster"
2324

2425
gemspec name: "factory_bot_rails", path: "../"

0 commit comments

Comments
 (0)