move log group data source to call site

Author: minaslater

aws/telemetry/main.tf

@@ -23,7 +23,7 @@ module "prometheus_workspace" {
   alert_resolve_timeout       = var.alert_resolve_timeout
   alert_subject_template      = var.alert_subject_template
   alertmanager_config_enabled = var.alertmanager_config_enabled
-  logging_configuration       = var.logging_configuration
+  log_group_arn               = var.log_group_arn
   name                        = var.prometheus_workspace_name
   tags                        = var.tags
 

aws/telemetry/modules/prometheus-workspace/main.tf

@@ -3,18 +3,13 @@ resource "aws_prometheus_workspace" "this" {
   tags  = var.tags
 
   dynamic logging_configuration {
-    for_each = var.logging_configuration
+    for_each = var.log_group_arn
     content {
-      log_group_arn = data.aws_cloudwatch_log_group.this[each.value].arn
+      log_group_arn = setting.value
     }
   }
 }
 
-data "aws_cloudwatch_log_group" "this" {
-  for_each = var.logging_configuration
-  name = each.value
-}
-
 resource "aws_iam_role" "ingestion" {
   assume_role_policy = data.aws_iam_policy_document.ingestion_assume_role.json
   name               = join("-", concat([var.name, "prometheus", "ingestion"]))

aws/telemetry/modules/prometheus-workspace/variables.tf

@@ -28,10 +28,10 @@ variable "alertmanager_config_enabled" {
   default     = true
 }
 
-variable "logging_configuration" {
-  description = "Cloudwatch logging configuration for Prometheus workspace"
-  type        = map(string)
-  default     = {}
+variable "log_group_arn" {
+  description = "ARN for the CW log group"
+  type        = list(string)
+  default     = []
 }
 
 variable "name" {

aws/telemetry/variables.tf

@@ -46,10 +46,10 @@ variable "alertmanager_config_enabled" {
   default     = true
 }
 
-variable "logging_configuration" {
-  description = "Cloudwatch logging configuration for Prometheus workspace"
-  type        = map(string)
-  default     = {}
+variable "log_group_arn" {
+  description = "ARN for the CW log group"
+  type        = list(string)
+  default     = []
 }
 
 variable "grafana_role_name" {