diff --git a/code-review/README.md b/code-review/README.md index daad5ea5..ab55fa90 100644 --- a/code-review/README.md +++ b/code-review/README.md @@ -30,6 +30,9 @@ Watch a presentation that covers this material from [Derek Prior at RailsConf 20 - **Be explicit** - Remember people don't always understand your intentions online. +- **When disagreeing, provide alternative solutions** + - Don't [simply reject an idea][dont-mcblock-me]. [Explain your reasoning](https://thoughtbot.com/blog/don-t-review-prs-like-a-space-wizard) and [suggest alternative approaches](https://github.com/thoughtbot/guides/pull/762#discussion_r2135772338). + - **Be humble** - "I'm not sure - let's look it up." @@ -133,3 +136,4 @@ This helps us have more meaningful conversations on PRs rather than debating per [challenging to convey emotion and intention online]: https://thoughtbot.com/blog/empathy-online [using labels]: https://conventionalcomments.org [standard]: https://github.com/testdouble/standard +[dont-mcblock-me]: https://www.schneems.com/2025/06/03/dont-mcblock-me