From 02b805165b9e0e98c8ef9a73f843e4b87ae02999 Mon Sep 17 00:00:00 2001 From: Matheus Richard Date: Fri, 6 Jun 2025 19:08:37 -0300 Subject: [PATCH 1/2] Add guidance on providing alternative solutions in reviews Encourage reviewers to explain their reasoning and suggest alternatives instead of simply rejecting ideas. This fosters constructive discussions and improves collaboration. --- code-review/README.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/code-review/README.md b/code-review/README.md index daad5ea5..00525bdd 100644 --- a/code-review/README.md +++ b/code-review/README.md @@ -30,6 +30,10 @@ Watch a presentation that covers this material from [Derek Prior at RailsConf 20 - **Be explicit** - Remember people don't always understand your intentions online. +- **When disagreeing, provide alternative solutions** + - Don't simply reject an idea. Explain your reasoning and [suggest alternative + approaches][dont-mcblock-me]. + - **Be humble** - "I'm not sure - let's look it up." @@ -133,3 +137,4 @@ This helps us have more meaningful conversations on PRs rather than debating per [challenging to convey emotion and intention online]: https://thoughtbot.com/blog/empathy-online [using labels]: https://conventionalcomments.org [standard]: https://github.com/testdouble/standard +[dont-mcblock-me]: https://www.schneems.com/2025/06/03/dont-mcblock-me From 21e86e89b52172b27700a92d7902c22683df45c1 Mon Sep 17 00:00:00 2001 From: Matheus Richard Date: Tue, 10 Jun 2025 14:48:00 -0300 Subject: [PATCH 2/2] Links! --- code-review/README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/code-review/README.md b/code-review/README.md index 00525bdd..ab55fa90 100644 --- a/code-review/README.md +++ b/code-review/README.md @@ -31,8 +31,7 @@ Watch a presentation that covers this material from [Derek Prior at RailsConf 20 - Remember people don't always understand your intentions online. - **When disagreeing, provide alternative solutions** - - Don't simply reject an idea. Explain your reasoning and [suggest alternative - approaches][dont-mcblock-me]. + - Don't [simply reject an idea][dont-mcblock-me]. [Explain your reasoning](https://thoughtbot.com/blog/don-t-review-prs-like-a-space-wizard) and [suggest alternative approaches](https://github.com/thoughtbot/guides/pull/762#discussion_r2135772338). - **Be humble** - "I'm not sure - let's look it up."