Fix linting

Author: neilvcarvalho

lib/parsers/audit_parser.rb

@@ -3,10 +3,10 @@
 module ImportmapUpdate
   module Parsers
     class AuditParser
-      SeverityLevel = Data.define(:level) do
-        SEVERITIES = %w[low moderate high critical].freeze
-        DEFAULT_SEVERITY_LEVEL = 0
+      SEVERITIES = %w[low moderate high critical].freeze
+      DEFAULT_SEVERITY_LEVEL = 0
 
+      SeverityLevel = Data.define(:level) do
         def self.from_name(name)
           level = SEVERITIES.index(name) || DEFAULT_SEVERITY_LEVEL
 
@@ -15,7 +15,7 @@ def self.from_name(name)
 
         def to_s = SEVERITIES[level]
 
-        def inspect = "SeverityLevel(#{to_s})"
+        def inspect = "SeverityLevel(#{self})"
       end
 
       Vulnerability = Data.define(:name, :severity, :vulnerable_versions, :advisory)

lib/parsers/markdown_table_parser.rb

@@ -16,10 +16,10 @@ def parse
 
         return [] if lines.empty?
 
-        header = lines.shift.split("|")[1..-1].map { symbolize(it) }
-        body = lines.map { |l| l.split("|")[1..-1].map(&:strip) }
+        header = lines.shift.split("|")[1..].map { symbolize(it) }
+        body = lines.map { |l| l.split("|")[1..].map(&:strip) }
 
-        body.map { |row| Hash[header.zip(row)] }
+        body.map { |row| header.zip(row).to_h }
       end
 
       private

lib/parsers/outdated_parser.rb

@@ -3,17 +3,17 @@
 module ImportmapUpdate
   module Parsers
     class OutdatedParser
-      OutdatedPackage = Data.define(:name, :current, :latest_or_error) do
-        VERSION_SHAPE_RE = /\Av?\d+\.\d+\.\d+(?:[-+][0-9A-Za-z.-]+)?\z/
+      VERSION_SHAPE_RE = /\Av?\d+\.\d+\.\d+(?:[-+][0-9A-Za-z.-]+)?\z/
 
+      OutdatedPackage = Data.define(:name, :current, :latest_or_error) do
         def latest
-          return nil unless latest_or_error =~ VERSION_SHAPE_RE
+          return nil unless VERSION_SHAPE_RE.match?(latest_or_error)
 
           latest_or_error
         end
 
         def error
-          return nil if latest_or_error =~ VERSION_SHAPE_RE
+          return nil if VERSION_SHAPE_RE.match?(latest_or_error)
 
           latest_or_error
         end

test/parsers/markdown_table_parser_test.rb

@@ -18,8 +18,8 @@ def test_parses_audit_markdown_table
     result = Parser.parse(table)
 
     expected = [
-      { package: "lodash", severity: "high", vulnerable_versions: "<4.17.21", vulnerability: "Prototype Pollution in lodash" },
-      { package: "@hotwired/stimulus", severity: "moderate", vulnerable_versions: "<3.2.2", vulnerability: "ReDoS in stimulus router" }
+      {package: "lodash", severity: "high", vulnerable_versions: "<4.17.21", vulnerability: "Prototype Pollution in lodash"},
+      {package: "@hotwired/stimulus", severity: "moderate", vulnerable_versions: "<3.2.2", vulnerability: "ReDoS in stimulus router"}
     ]
 
     assert_equal expected, result
@@ -38,9 +38,9 @@ def test_parses_outdated_markdown_table
     result = Parser.parse(table)
 
     expected = [
-      { package: "@hotwired/stimulus", current: "3.2.1", latest: "3.2.2" },
-      { package: "lodash", current: "4.17.20", latest: "4.17.21" },
-      { package: "react", current: "18.2.0", latest: "19.0.0" }
+      {package: "@hotwired/stimulus", current: "3.2.1", latest: "3.2.2"},
+      {package: "lodash", current: "4.17.20", latest: "4.17.21"},
+      {package: "react", current: "18.2.0", latest: "19.0.0"}
     ]
 
     assert_equal expected, result