Add keyword args, update spec, and bug

Changing get_paged_chanels to take keyword args.
Updating the loads_slack_channels spec for testing pagination to include
the pagination cursor.
Including types when calling get_paged_channels (bug fix)

Author: sej3506

app/services/slack/loads_slack_channels.rb

@@ -14,7 +14,7 @@ def call(types:)
         ClientWrapper.client.conversations_list(types: approved_types(types), limit: 1000, exclude_archived: true)
       end
 
-      get_paged_channels(response&.response_metadata&.next_cursor, response&.channels || [])
+      get_paged_channels(cursor: response&.response_metadata&.next_cursor, channels: response&.channels || [], types: types)
     end
 
     private
@@ -23,11 +23,11 @@ def approved_types(types)
       types.split(",").select { |t| SLACK_CHANNEL_TYPES.include?(t) }.join(",")
     end
 
-    def get_paged_channels(cursor, channels)
+    def get_paged_channels(cursor:, channels:, types:)
       while cursor.present?
         response = ClientWrapper.client.conversations_list(cursor: cursor, types: approved_types(types), limit: 1000, exclude_archived: true)
         channels.append(response.channels)
-        cursor = response.response_metadata.next_cursor
+        cursor = response.response_metadata&.next_cursor
       end
 
       channels.flatten

spec/lib/slack/loads_slack_channels_spec.rb

@@ -37,21 +37,19 @@
   end
 
   it "loads all active channels when requiring pagination" do
-    archived_slack_public_channel = Slack::Messages::Message.new(
-      id: "PUBLIC_CHANNEL_ID_2",
-      is_channel: true,
-      is_archived: true
-    )
     slack_public_channels = (0..1010).map do |ch|
       Slack::Messages::Message.new(
         id: "PUBLIC_CHANNEL_ID_#{ch}",
         is_channel: true
       )
     end
-    all_channels = slack_public_channels << archived_slack_public_channel
 
+    response_metadata = Slack::Messages::Message.new(next_cursor: "cursor")
     expect(@slack_client).to receive(:conversations_list).with(types: "public_channel", limit: 1000, exclude_archived: true) {
-      Slack::Messages::Message.new(ok: true, channels: all_channels)
+      Slack::Messages::Message.new(ok: true, response_metadata: response_metadata, channels: slack_public_channels[0..999])
+    }
+    expect(@slack_client).to receive(:conversations_list).with(types: "public_channel", limit: 1000, exclude_archived: true, cursor: response_metadata.next_cursor) {
+      Slack::Messages::Message.new(ok: true, channels: slack_public_channels[1000..])
     }
 
     channels = subject.call(types: "public_channel")