Different prefixes are not detected by `with_prefix`

[deniciocode]

Description

When having two enums with the same string values in two different prefixes
will not be distinguished by with_prefix and the tests pass.

Reproduction Steps

class ContactSuggestion < ApplicationRecord
  STATUSES = { pending: 'pending', denied: 'denied', agreed: 'agreed' }.freeze

  enum :candidate_user_status, STATUSES, prefix: :user
  enum :candidate_contact_status, STATUSES, prefix: :contact
end

describe 'validations' do
  subject(:described_instance) { described_class.new }

  it do
    expect(described_instance).to define_enum_for(:candidate_user_status)
      .with_values(agreed: 'agreed', pending: 'pending', denied: 'denied')
      .with_prefix(:user) 
  end

  it do
    expect(described_instance).to define_enum_for(:candidate_contact_status)
      .with_values(agreed: 'agreed', pending: 'pending', denied: 'denied')
      .with_prefix(:user) # Wrong prefix here
  end
end

Expected behavior

As a user I would expect and hint by a failing spec that points out that candidate_contact_status is not prefixed by :user

Actual behavior

The test passes with not harm or information.

System configuration

shoulda_matchers version: 6.4.0
rails version: 8.0.1
ruby version: 3.3.4

[stefannibrasil]

I am trying to replicate the exact issue:

unit tests

branch: https://github.com/thoughtbot/shoulda-matchers/compare/main...hexdevs:shoulda-matchers:sb-replicating-1659?expand=1

I couldn't reproduce the issue as shared above. When there are different attributes with the same enum values with different prefixes, and I assert against the wrong prefix, this fails but shouldn't according to the bug report.

minimal rails app

I was able to reproduce it in a minimal rails app though.

# frozen_string_literal: true

require "bundler/inline"

gemfile(true) do
  source "https://rubygems.org"

  gem "rails", '8.0.1'
  gem "sqlite3"

  gem "shoulda-context"
  gem "shoulda-matchers", '6.4.0'
  gem 'test-unit'
end

require "active_record/railtie"
require "minitest/autorun"
require "shoulda/context"
require "shoulda-matchers"

# This connection will do for database-independent bug reports.
ENV["DATABASE_URL"] = "sqlite3::memory:"

Shoulda::Matchers.configure do |config|
  config.integrate do |with|
    with.test_framework :minitest
    with.library :active_record
    with.library :active_model
  end
end

class TestApp < Rails::Application
  config.load_defaults Rails::VERSION::STRING.to_f
  config.eager_load = false
  config.logger = Logger.new($stdout)
  config.secret_key_base = "secret_key_base"

  config.active_record.encryption.primary_key = "primary_key"
  config.active_record.encryption.deterministic_key = "deterministic_key"
  config.active_record.encryption.key_derivation_salt = "key_derivation_salt"
end
Rails.application.initialize!

ActiveRecord::Schema.define do
  create_table :contact_suggestions, force: true do |t|
    t.string :candidate_user_status
    t.string :candidate_contact_status
  end
end

class ContactSuggestion < ActiveRecord::Base
  STATUSES = { pending: 'pending', denied: 'denied', agreed: 'agreed' }

  enum :candidate_user_status, STATUSES, prefix: :user
  enum :candidate_contact_status, STATUSES, prefix: :contact
end

class ContactSuggestionTest < ActiveSupport::TestCase
  def test_enum_with_same_values_and_different_prefixes
    assert_nil ContactSuggestion.new.candidate_user_status
    assert_nil ContactSuggestion.new.candidate_contact_status

    user_status = ContactSuggestion.create!(candidate_user_status: 'agreed', candidate_contact_status: 'agreed')

    assert_equal 'agreed', user_status.candidate_user_status
    assert user_status.user_agreed?

    assert_equal 'agreed', user_status.candidate_user_status
    refute user_status.contact_pending?
    assert user_status.contact_agreed?

    ContactSuggestion.create!(candidate_user_status: 'denied', candidate_contact_status: 'denied')
    ContactSuggestion.create!(candidate_user_status: 'pending', candidate_contact_status: 'pending')
  end

  context 'these should pass' do
    should define_enum_for(:candidate_user_status).
      backed_by_column_of_type(:string).
      with_values(pending: "pending", denied: 'denied', agreed: 'agreed').
      with_prefix(:user)

    should define_enum_for(:candidate_contact_status).
      backed_by_column_of_type(:string).
      with_values(pending: "pending", denied: 'denied', agreed: 'agreed').
      with_prefix(:contact)
  end

  context 'these should fail but pass' do
    should define_enum_for(:candidate_user_status).
      backed_by_column_of_type(:string).
      with_values(pending: "pending", denied: 'denied', agreed: 'agreed').
      with_prefix(:contact)

    should define_enum_for(:candidate_contact_status).
      backed_by_column_of_type(:string).
      with_values(pending: "pending", denied: 'denied', agreed: 'agreed').
      with_prefix(:user)
  end
end

I am not sure how to go from here, especially because I couldn't reproduce it with the unit tests. Does this mean it's not a shoulda-matchers issue?

@matsales28 any ideas?

[stefannibrasil]

hi @matsales28 just checking in to see if you have any ideas on how to move forward with this issue. Thank you!

[matsales28]

Hmm, this is interesting. It looks like there might be a step we’re missing in the shoulda-matchers test that is present in the minimal script. I’d start by trying to fix the issue using the minimal script, then replicate that same test in the shoulda-matchers suite to make sure it doesn’t fail there as well.

[stefannibrasil]

Hi, Mateus! Thanks for sharing your thoughts. That sounds like a good plan. I will come back to this soon.