Skip to content

Commit 8aa6efb

Browse files
Lint Generator: Remove generated test/spec files
Follow-up to #1148 I noticed these tests did not fail even if `bin/rails standard` raised a linting violation. Because the upcoming `suspenders:ci` generator will run our linting tasks in CI, I felt having a test to do the same was no longer warranted.
1 parent f3f4480 commit 8aa6efb

File tree

4 files changed

+0
-58
lines changed

4 files changed

+0
-58
lines changed

lib/generators/suspenders/lint_generator.rb

-6
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,6 @@ def configure_erb_lint
4242
copy_file "config_initializers_better_html.rb", "config/initializers/better_html.rb"
4343
copy_file "erblint.rake", "lib/tasks/erblint.rake"
4444
template "rubocop.yml.tt", ".rubocop.yml"
45-
46-
if default_test_suite?
47-
copy_file "better_html_test.rb", "test/views/better_html_test.rb"
48-
elsif rspec_test_suite?
49-
copy_file "better_html_spec.rb", "spec/views/better_html_spec.rb"
50-
end
5145
end
5246

5347
def update_package_json

lib/generators/templates/lint/better_html_spec.rb

-17
This file was deleted.

lib/generators/templates/lint/better_html_test.rb

-17
This file was deleted.

test/generators/suspenders/lint_generator_test.rb

-18
Original file line numberDiff line numberDiff line change
@@ -220,24 +220,6 @@ class LintGeneratorTest < Rails::Generators::TestCase
220220
end
221221
end
222222

223-
test "generates erb-lint tests" do
224-
with_test_suite :minitest do
225-
capture(:stderr) { run_generator }
226-
227-
assert_file app_root("test/views/better_html_test.rb")
228-
assert_no_file app_root("spec/views/better_html_spec.rb")
229-
end
230-
end
231-
232-
test "generates erb-lint specs" do
233-
with_test_suite :rspec do
234-
capture(:stderr) { run_generator }
235-
236-
assert_file app_root("spec/views/better_html_spec.rb")
237-
assert_no_file app_root("test/views/better_html_test.rb")
238-
end
239-
end
240-
241223
test "generates .rubocop.yml" do
242224
expected_content = <<~YAML
243225
AllCops:

0 commit comments

Comments
 (0)