Pass alb variables to alb module from root module

Author: OlamideOl1

modules/alb/README.md

@@ -38,7 +38,7 @@ No modules.
 | <a name="input_enable_access_logs"></a> [enable\_access\_logs](#input\_enable\_access\_logs) | Enable or disable ALB access logs. If set to true, logs will be stored in an S3 bucket. | `bool` | `false` | no |
 | <a name="input_enable_connection_logs"></a> [enable\_connection\_logs](#input\_enable\_connection\_logs) | Enable or disable ALB connection logs. If set to true, logs will be stored in an S3 bucket. | `bool` | `false` | no |
 | <a name="input_name"></a> [name](#input\_name) | Name for this load balancer | `string` | n/a | yes |
-| <a name="input_s3_bucket_name"></a> [s3\_bucket\_name](#input\_s3\_bucket\_name) | Optional S3 bucket name for storing ALB access logs. If not provided, a new bucket will be created. | `string` | `""` | no |
+| <a name="input_s3_logs_bucket_name"></a> [s3\_bucket\_name](#input\_s3\_bucket\_name) | Optional S3 bucket name for storing ALB access logs. If not provided, a new bucket will be created. | `string` | `""` | no |
 | <a name="input_security_group_name"></a> [security\_group\_name](#input\_security\_group\_name) | Name for the load balancer security group; defaults to name | `string` | `null` | no |
 | <a name="input_subnet_ids"></a> [subnet\_ids](#input\_subnet\_ids) | Subnets for this load balancer | `list(string)` | n/a | yes |
 | <a name="input_tags"></a> [tags](#input\_tags) | Tags to apply to created resources | `map(string)` | `{}` | no |

modules/alb/main.tf

@@ -5,7 +5,7 @@ resource "aws_alb" "this" {
   dynamic "connection_logs" {
     for_each = var.enable_connection_logs ? [1] : []
     content {
-      bucket  = var.s3_bucket_name != "" ? var.s3_bucket_name : aws_s3_bucket.lb_logs[0].id
+      bucket  = var.s3_logs_bucket_name != "" ? var.s3_logs_bucket_name : aws_s3_bucket.lb_logs[0].id
       prefix  = "connectionlogs"
       enabled = true
     }
@@ -14,7 +14,7 @@ resource "aws_alb" "this" {
   dynamic "access_logs" {
     for_each = var.enable_access_logs ? [1] : []
     content {
-      bucket  = var.s3_bucket_name != "" ? var.s3_bucket_name : aws_s3_bucket.lb_logs[0].id
+      bucket  = var.s3_logs_bucket_name != "" ? var.s3_logs_bucket_name : aws_s3_bucket.lb_logs[0].id
       prefix  = "accesslogs"
       enabled = true
     }
@@ -24,8 +24,8 @@ resource "aws_alb" "this" {
 }
 
 resource "aws_s3_bucket" "lb_logs" {
-  count  = var.s3_bucket_name == "" ? 1 : 0
-  bucket = var.s3_bucket_name == "" ? "${var.name}-alb-logs-${random_id.suffix.hex}" : var.s3_bucket_name
+  count  = var.s3_logs_bucket_name == "" ? 1 : 0
+  bucket = var.s3_logs_bucket_name == "" ? "${var.name}-alb-logs-${random_id.suffix.hex}" : var.s3_logs_bucket_name
 }
 
 resource "random_id" "suffix" {

modules/alb/variables.tf

@@ -20,7 +20,7 @@ variable "name" {
   type        = string
 }
 
-variable "s3_bucket_name" {
+variable "s3_logs_bucket_name" {
   type        = string
   default     = ""
   description = "Optional S3 bucket name for storing ALB access logs. If not provided, a new bucket will be created."

variables.tf

@@ -38,6 +38,17 @@ variable "description" {
   type        = string
 }
 
+variable "enable_access_logs" {
+  type        = bool
+  default     = false
+  description = "Enable or disable ALB access logs. If set to true, logs will be stored in an S3 bucket."
+}
+
+variable "enable_connection_logs" {
+  type        = bool
+  default     = false
+  description = "Enable or disable ALB connection logs. If set to true, logs will be stored in an S3 bucket."
+}
 variable "enable_stickiness" {
   type        = bool
   description = "Set to true to use a cookie for load balancer stickiness"
@@ -78,6 +89,12 @@ variable "primary_certificate_domain" {
   type        = string
 }
 
+variable "s3_logs_bucket_name" {
+  type        = string
+  default     = ""
+  description = "Optional S3 bucket name for storing ALB access logs. If not provided, a new bucket will be created."
+}
+
 variable "security_group_name" {
   type        = string
   description = "Name for the load balancer security group; defaults to name"