Skip to content

Commit b28d0ad

Browse files
mwaykolethrecc
authored andcommitted
Fix timing issue for the test (opendatahub-io#1334)
Signed-off-by: Milind waykole <mwaykole@redhat.com>
1 parent f2c4833 commit b28d0ad

File tree

1 file changed

+21
-5
lines changed
  • tests/model_serving/model_server/kserve/authentication

1 file changed

+21
-5
lines changed

tests/model_serving/model_server/kserve/authentication/conftest.py

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
from utilities.infra import (
2828
create_inference_token,
2929
create_isvc_view_role,
30-
get_pods_by_isvc_label,
30+
wait_for_inference_deployment_replicas,
3131
)
3232
from utilities.jira import is_jira_open
3333
from utilities.logger import RedactedString
@@ -95,12 +95,28 @@ def patched_remove_raw_authentication_isvc(
9595
}
9696
}
9797
):
98-
if is_jira_open(jira_id="RHOAIENG-52129", admin_client=admin_client):
99-
LOGGER.info("RHOAIENG-52129 is open; waiting for predictor pod rollout after auth toggle")
100-
predictor_pod.wait_deleted()
101-
98+
http_s3_ovms_raw_inference_service.wait_for_condition(
99+
condition=http_s3_ovms_raw_inference_service.Condition.READY,
100+
status=http_s3_ovms_raw_inference_service.Condition.Status.TRUE,
101+
timeout=Timeout.TIMEOUT_2MIN,
102+
)
103+
wait_for_inference_deployment_replicas(
104+
client=unprivileged_client,
105+
isvc=http_s3_ovms_raw_inference_service,
106+
)
102107
yield http_s3_ovms_raw_inference_service
103108

109+
# ResourceEditor restores auth on exit; wait for ISVC to reconcile before next test
110+
http_s3_ovms_raw_inference_service.wait_for_condition(
111+
condition=http_s3_ovms_raw_inference_service.Condition.READY,
112+
status=http_s3_ovms_raw_inference_service.Condition.Status.TRUE,
113+
timeout=Timeout.TIMEOUT_2MIN,
114+
)
115+
wait_for_inference_deployment_replicas(
116+
client=unprivileged_client,
117+
isvc=http_s3_ovms_raw_inference_service,
118+
)
119+
104120

105121
@pytest.fixture(scope="class")
106122
def model_service_account_2(

0 commit comments

Comments
 (0)