Skip to content

Commit 0164d65

Browse files
committed
Make attribute getting behaviour of DummyEnvWorker compatible with gymnasium v1
1 parent e69d0f9 commit 0164d65

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

test/base/test_env.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,8 +213,6 @@ def test_attr_unwrapped() -> None:
213213
train_envs = DummyVectorEnv([lambda: gym.make("CartPole-v1")])
214214
train_envs.set_env_attr("test_attribute", 1337)
215215
assert train_envs.get_env_attr("test_attribute") == [1337]
216-
# mypy doesn't know but BaseVectorEnv takes the reserved keys in gym.Env (one of which is env)
217-
assert hasattr(train_envs.workers[0].env, "test_attribute") # type: ignore
218216
assert hasattr(train_envs.workers[0].env.unwrapped, "test_attribute") # type: ignore
219217

220218

tianshou/env/worker/dummy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def __init__(self, env_fn: Callable[[], gym.Env]) -> None:
1515
super().__init__(env_fn)
1616

1717
def get_env_attr(self, key: str) -> Any:
18-
return getattr(self.env, key)
18+
return getattr(self.env.unwrapped, key)
1919

2020
def set_env_attr(self, key: str, value: Any) -> None:
2121
setattr(self.env.unwrapped, key, value)

0 commit comments

Comments
 (0)