Remove unused observability dependency from flow executors

Fixes #<issue>: Remove unused observabilitySvc field and constructor
parameter from basicAuthExecutor, smsOTPAuthExecutor, and
passkeyAuthExecutor. Update init.go and test files accordingly.

Agent-Logs-Url: https://github.com/asgardeo/thunder/sessions/7c391fb8-bc64-484d-aeae-6d54ef3a0a1b

Co-authored-by: rajithacharith <32898873+rajithacharith@users.noreply.github.com>

Author: Copilot

backend/internal/flow/executor/basic_auth_executor.go

@@ -31,18 +31,16 @@ import (
 	"github.com/asgardeo/thunder/internal/flow/core"
 	"github.com/asgardeo/thunder/internal/system/error/serviceerror"
 	"github.com/asgardeo/thunder/internal/system/log"
-	"github.com/asgardeo/thunder/internal/system/observability"
 	"github.com/asgardeo/thunder/internal/userprovider"
 )
 
 // basicAuthExecutor implements the ExecutorInterface for basic authentication.
 type basicAuthExecutor struct {
 	core.ExecutorInterface
 	identifyingExecutorInterface
-	userProvider     userprovider.UserProviderInterface
-	credsAuthSvc     authncreds.CredentialsAuthnServiceInterface
-	observabilitySvc observability.ObservabilityServiceInterface
-	logger           *log.Logger
+	userProvider userprovider.UserProviderInterface
+	credsAuthSvc authncreds.CredentialsAuthnServiceInterface
+	logger       *log.Logger
 }
 
 var _ core.ExecutorInterface = (*basicAuthExecutor)(nil)
@@ -53,7 +51,6 @@ func newBasicAuthExecutor(
 	flowFactory core.FlowFactoryInterface,
 	userProvider userprovider.UserProviderInterface,
 	credsAuthSvc authncreds.CredentialsAuthnServiceInterface,
-	observabilitySvc observability.ObservabilityServiceInterface,
 ) *basicAuthExecutor {
 	defaultInputs := []common.Input{
 		{
@@ -81,7 +78,6 @@ func newBasicAuthExecutor(
 		identifyingExecutorInterface: identifyExec,
 		userProvider:                 userProvider,
 		credsAuthSvc:                 credsAuthSvc,
-		observabilitySvc:             observabilitySvc,
 		logger:                       logger,
 	}
 }

backend/internal/flow/executor/basic_auth_executor_test.go

@@ -36,17 +36,15 @@ import (
 	"github.com/asgardeo/thunder/internal/userprovider"
 	"github.com/asgardeo/thunder/tests/mocks/authn/credentialsmock"
 	"github.com/asgardeo/thunder/tests/mocks/flow/coremock"
-	"github.com/asgardeo/thunder/tests/mocks/observability/observabilitymock"
 	"github.com/asgardeo/thunder/tests/mocks/userprovidermock"
 )
 
 type BasicAuthExecutorTestSuite struct {
 	suite.Suite
-	mockUserProvider  *userprovidermock.UserProviderInterfaceMock
-	mockCredsService  *credentialsmock.CredentialsAuthnServiceInterfaceMock
-	mockFlowFactory   *coremock.FlowFactoryInterfaceMock
-	mockObservability *observabilitymock.ObservabilityServiceInterfaceMock
-	executor          *basicAuthExecutor
+	mockUserProvider *userprovidermock.UserProviderInterfaceMock
+	mockCredsService *credentialsmock.CredentialsAuthnServiceInterfaceMock
+	mockFlowFactory  *coremock.FlowFactoryInterfaceMock
+	executor         *basicAuthExecutor
 }
 
 func TestBasicAuthExecutorSuite(t *testing.T) {
@@ -57,7 +55,6 @@ func (suite *BasicAuthExecutorTestSuite) SetupTest() {
 	suite.mockUserProvider = userprovidermock.NewUserProviderInterfaceMock(suite.T())
 	suite.mockCredsService = credentialsmock.NewCredentialsAuthnServiceInterfaceMock(suite.T())
 	suite.mockFlowFactory = coremock.NewFlowFactoryInterfaceMock(suite.T())
-	suite.mockObservability = observabilitymock.NewObservabilityServiceInterfaceMock(suite.T())
 
 	defaultInputs := []common.Input{
 		{Identifier: userAttributeUsername, Type: common.InputTypeText, Required: true},
@@ -73,13 +70,7 @@ func (suite *BasicAuthExecutorTestSuite) SetupTest() {
 	suite.mockFlowFactory.On("CreateExecutor", ExecutorNameBasicAuth, common.ExecutorTypeAuthentication,
 		defaultInputs, []common.Input{}).Return(mockExec)
 
-	suite.executor = newBasicAuthExecutor(suite.mockFlowFactory, suite.mockUserProvider, suite.mockCredsService,
-		suite.mockObservability)
-}
-
-func (suite *BasicAuthExecutorTestSuite) BeforeTest(suiteName, testName string) {
-	suite.mockObservability.ExpectedCalls = nil
-	suite.mockObservability.On("IsEnabled").Return(false).Maybe()
+	suite.executor = newBasicAuthExecutor(suite.mockFlowFactory, suite.mockUserProvider, suite.mockCredsService)
 }
 
 func createMockIdentifyingExecutor(t *testing.T) core.ExecutorInterface {

backend/internal/flow/executor/init.go

@@ -59,11 +59,11 @@ func Initialize(
 ) ExecutorRegistryInterface {
 	reg := newExecutorRegistry()
 	reg.RegisterExecutor(ExecutorNameBasicAuth, newBasicAuthExecutor(
-		flowFactory, userProvider, authRegistry.CredentialsAuthnService, observabilitySvc))
+		flowFactory, userProvider, authRegistry.CredentialsAuthnService))
 	reg.RegisterExecutor(ExecutorNameSMSAuth, newSMSOTPAuthExecutor(
-		flowFactory, otpService, observabilitySvc, userProvider))
+		flowFactory, otpService, userProvider))
 	reg.RegisterExecutor(ExecutorNamePasskeyAuth, newPasskeyAuthExecutor(
-		flowFactory, authRegistry.PasskeyService, observabilitySvc, userProvider))
+		flowFactory, authRegistry.PasskeyService, userProvider))
 
 	reg.RegisterExecutor(ExecutorNameOAuth, newOAuthExecutor(
 		"", []common.Input{}, []common.Input{}, flowFactory, idpService, userSchemaService,

backend/internal/flow/executor/passkey_executor.go

@@ -29,7 +29,6 @@ import (
 	"github.com/asgardeo/thunder/internal/flow/core"
 	"github.com/asgardeo/thunder/internal/system/error/serviceerror"
 	"github.com/asgardeo/thunder/internal/system/log"
-	"github.com/asgardeo/thunder/internal/system/observability"
 	"github.com/asgardeo/thunder/internal/userprovider"
 )
 
@@ -71,10 +70,9 @@ const (
 type passkeyAuthExecutor struct {
 	core.ExecutorInterface
 	identifyingExecutorInterface
-	passkeyService   passkey.PasskeyServiceInterface
-	userProvider     userprovider.UserProviderInterface
-	observabilitySvc observability.ObservabilityServiceInterface
-	logger           *log.Logger
+	passkeyService passkey.PasskeyServiceInterface
+	userProvider   userprovider.UserProviderInterface
+	logger         *log.Logger
 }
 
 var _ core.ExecutorInterface = (*passkeyAuthExecutor)(nil)
@@ -84,7 +82,6 @@ var _ identifyingExecutorInterface = (*passkeyAuthExecutor)(nil)
 func newPasskeyAuthExecutor(
 	flowFactory core.FlowFactoryInterface,
 	passkeyService passkey.PasskeyServiceInterface,
-	observabilitySvc observability.ObservabilityServiceInterface,
 	userProvider userprovider.UserProviderInterface,
 ) *passkeyAuthExecutor {
 	defaultInputs := []common.Input{
@@ -136,7 +133,6 @@ func newPasskeyAuthExecutor(
 		identifyingExecutorInterface: identifyExec,
 		passkeyService:               passkeyService,
 		userProvider:                 userProvider,
-		observabilitySvc:             observabilitySvc,
 		logger:                       logger,
 	}
 }

backend/internal/flow/executor/passkey_executor_test.go

@@ -34,7 +34,6 @@ import (
 	"github.com/asgardeo/thunder/internal/userprovider"
 	"github.com/asgardeo/thunder/tests/mocks/authn/passkeymock"
 	"github.com/asgardeo/thunder/tests/mocks/flow/coremock"
-	"github.com/asgardeo/thunder/tests/mocks/observability/observabilitymock"
 	"github.com/asgardeo/thunder/tests/mocks/userprovidermock"
 )
 
@@ -52,7 +51,6 @@ type PasskeyAuthExecutorTestSuite struct {
 	suite.Suite
 	mockPasskeyService *passkeymock.PasskeyServiceInterfaceMock
 	mockFlowFactory    *coremock.FlowFactoryInterfaceMock
-	mockObservability  *observabilitymock.ObservabilityServiceInterfaceMock
 	mockUserProvider   *userprovidermock.UserProviderInterfaceMock
 	executor           *passkeyAuthExecutor
 }
@@ -64,7 +62,6 @@ func TestPasskeyAuthExecutorSuite(t *testing.T) {
 func (suite *PasskeyAuthExecutorTestSuite) SetupTest() {
 	suite.mockPasskeyService = passkeymock.NewPasskeyServiceInterfaceMock(suite.T())
 	suite.mockFlowFactory = coremock.NewFlowFactoryInterfaceMock(suite.T())
-	suite.mockObservability = observabilitymock.NewObservabilityServiceInterfaceMock(suite.T())
 	suite.mockUserProvider = userprovidermock.NewUserProviderInterfaceMock(suite.T())
 
 	// Create mock identifying executor
@@ -78,12 +75,7 @@ func (suite *PasskeyAuthExecutorTestSuite) SetupTest() {
 		mock.Anything, mock.Anything).Return(mockExec)
 
 	suite.executor = newPasskeyAuthExecutor(suite.mockFlowFactory,
-		suite.mockPasskeyService, suite.mockObservability, suite.mockUserProvider)
-}
-
-func (suite *PasskeyAuthExecutorTestSuite) BeforeTest(suiteName, testName string) {
-	suite.mockObservability.ExpectedCalls = nil
-	suite.mockObservability.On("IsEnabled").Return(false).Maybe()
+		suite.mockPasskeyService, suite.mockUserProvider)
 }
 
 func createMockPasskeyAuthExecutor(t *testing.T) core.ExecutorInterface {

backend/internal/flow/executor/sms_auth_executor.go

@@ -30,7 +30,6 @@ import (
 	"github.com/asgardeo/thunder/internal/notification"
 	notifcommon "github.com/asgardeo/thunder/internal/notification/common"
 	"github.com/asgardeo/thunder/internal/system/log"
-	"github.com/asgardeo/thunder/internal/system/observability"
 	"github.com/asgardeo/thunder/internal/userprovider"
 )
 
@@ -46,10 +45,9 @@ var MobileNumberInput = common.Input{
 type smsOTPAuthExecutor struct {
 	core.ExecutorInterface
 	identifyingExecutorInterface
-	userProvider     userprovider.UserProviderInterface
-	otpService       notification.OTPServiceInterface
-	observabilitySvc observability.ObservabilityServiceInterface
-	logger           *log.Logger
+	userProvider userprovider.UserProviderInterface
+	otpService   notification.OTPServiceInterface
+	logger       *log.Logger
 }
 
 var _ core.ExecutorInterface = (*smsOTPAuthExecutor)(nil)
@@ -59,7 +57,6 @@ var _ identifyingExecutorInterface = (*smsOTPAuthExecutor)(nil)
 func newSMSOTPAuthExecutor(
 	flowFactory core.FlowFactoryInterface,
 	otpService notification.OTPServiceInterface,
-	observabilitySvc observability.ObservabilityServiceInterface,
 	userProvider userprovider.UserProviderInterface,
 ) *smsOTPAuthExecutor {
 	defaultInputs := []common.Input{
@@ -87,7 +84,6 @@ func newSMSOTPAuthExecutor(
 		identifyingExecutorInterface: identifyExec,
 		userProvider:                 userProvider,
 		otpService:                   otpService,
-		observabilitySvc:             observabilitySvc,
 		logger:                       logger,
 	}
 }

backend/internal/flow/executor/sms_auth_executor_test.go

@@ -32,17 +32,15 @@ import (
 	"github.com/asgardeo/thunder/internal/userprovider"
 	"github.com/asgardeo/thunder/tests/mocks/flow/coremock"
 	"github.com/asgardeo/thunder/tests/mocks/notification/notificationmock"
-	"github.com/asgardeo/thunder/tests/mocks/observability/observabilitymock"
 	"github.com/asgardeo/thunder/tests/mocks/userprovidermock"
 )
 
 type SMSAuthExecutorTestSuite struct {
 	suite.Suite
-	mockOTPService    *notificationmock.OTPServiceInterfaceMock
-	mockFlowFactory   *coremock.FlowFactoryInterfaceMock
-	mockObservability *observabilitymock.ObservabilityServiceInterfaceMock
-	mockUserProvider  *userprovidermock.UserProviderInterfaceMock
-	executor          *smsOTPAuthExecutor
+	mockOTPService   *notificationmock.OTPServiceInterfaceMock
+	mockFlowFactory  *coremock.FlowFactoryInterfaceMock
+	mockUserProvider *userprovidermock.UserProviderInterfaceMock
+	executor         *smsOTPAuthExecutor
 }
 
 func TestSMSAuthExecutorSuite(t *testing.T) {
@@ -52,12 +50,8 @@ func TestSMSAuthExecutorSuite(t *testing.T) {
 func (suite *SMSAuthExecutorTestSuite) SetupTest() {
 	suite.mockOTPService = notificationmock.NewOTPServiceInterfaceMock(suite.T())
 	suite.mockFlowFactory = coremock.NewFlowFactoryInterfaceMock(suite.T())
-	suite.mockObservability = observabilitymock.NewObservabilityServiceInterfaceMock(suite.T())
 	suite.mockUserProvider = userprovidermock.NewUserProviderInterfaceMock(suite.T())
 
-	// Default behavior for observability: disabled
-	suite.mockObservability.On("IsEnabled").Return(false).Maybe()
-
 	defaultInputs := []common.Input{
 		{
 			Ref:        "otp_input",
@@ -98,7 +92,7 @@ func (suite *SMSAuthExecutorTestSuite) SetupTest() {
 		defaultInputs, prerequisites).Return(mockExec)
 
 	suite.executor = newSMSOTPAuthExecutor(suite.mockFlowFactory,
-		suite.mockOTPService, suite.mockObservability, suite.mockUserProvider)
+		suite.mockOTPService, suite.mockUserProvider)
 	// Inject the mock base executor
 	suite.executor.ExecutorInterface = mockExec
 }