Upgrade golang v1.23 (kubernetes-sigs#350)

* chore: update go v1.23 in go.mod

* chore: update go v1.23 in hack/tools/go.mod

* chore: update go v1.23 in site/go.mod

* chore(site): update google/docsy

* chore: update go v1.23 in .go-version

* chore: udpate golangci-lint v1.62.2

* wip(lint): fix lint errors

* fix(lint): deprecate ast.NewPackage

* chore: update hugo v0.140.0

Author: danilo-gemoli

.go-version

@@ -1 +1 @@
-1.21.0
+1.23.0

cmd/checkconfig/main.go

@@ -1526,7 +1526,7 @@ func validateRequiredJobAnnotations(a []string, c config.JobConfig) error {
 		var errs []error
 		for _, annotation := range annotations {
 			if _, ok := job.Annotations[annotation]; !ok {
-				errs = append(errs, fmt.Errorf(annotation))
+				errs = append(errs, fmt.Errorf("%s", annotation))
 			}
 		}
 		return utilerrors.NewAggregate(errs)

cmd/peribolos/main.go

@@ -1287,7 +1287,7 @@ func configureTeamMembers(client teamMembersClient, orgName string, gt github.Te
 		if err != nil {
 			// Augment the error with the operation we attempted so that the error makes sense after return
 			err = fmt.Errorf("UpdateTeamMembership(%s(%s), %s, %t) failed: %w", gt.Slug, gt.Name, user, super, err)
-			logrus.Warnf(err.Error())
+			logrus.Warnf("%s", err.Error())
 		} else if tm.State == github.StatePending {
 			logrus.Infof("Invited %s to %s(%s) as a %s", user, gt.Slug, gt.Name, role)
 		} else {
@@ -1301,7 +1301,7 @@ func configureTeamMembers(client teamMembersClient, orgName string, gt github.Te
 		if err != nil {
 			// Augment the error with the operation we attempted so that the error makes sense after return
 			err = fmt.Errorf("RemoveTeamMembership(%s(%s), %s) failed: %w", gt.Slug, gt.Name, user, err)
-			logrus.Warnf(err.Error())
+			logrus.Warnf("%s", err.Error())
 		} else {
 			logrus.Infof("Removed %s from team %s(%s)", user, gt.Slug, gt.Name)
 		}

go.mod

@@ -1,6 +1,6 @@
 module sigs.k8s.io/prow
 
-go 1.22.3
+go 1.23
 
 require (
 	cloud.google.com/go/cloudbuild v1.16.5

hack/gen-prow-documented/main.go

@@ -17,11 +17,14 @@ limitations under the License.
 package main
 
 import (
+	"errors"
 	"flag"
 	"fmt"
 	"os"
 	"path"
 	"path/filepath"
+	"runtime/debug"
+	"strings"
 
 	"github.com/sirupsen/logrus"
 	"sigs.k8s.io/prow/pkg/config"
@@ -58,7 +61,7 @@ type genConfig struct {
 	out    string
 }
 
-func (g *genConfig) gen(rootDir string) error {
+func (g *genConfig) gen(rootDir string, importPathResolver genyaml.ImportPathResolver) error {
 	var inputFiles []string
 	for _, goGlob := range g.in {
 		ifs, err := filepath.Glob(path.Join(rootDir, goGlob))
@@ -68,7 +71,7 @@ func (g *genConfig) gen(rootDir string) error {
 		inputFiles = append(inputFiles, ifs...)
 	}
 
-	commentMap, err := genyaml.NewCommentMap(nil, inputFiles...)
+	commentMap, err := genyaml.NewCommentMap(importPathResolver, nil, inputFiles...)
 	if err != nil {
 		return fmt.Errorf("failed to construct commentMap: %w", err)
 	}
@@ -82,12 +85,37 @@ func (g *genConfig) gen(rootDir string) error {
 	return nil
 }
 
+func importPathResolverFunc(root string) (genyaml.ImportPathResolver, error) {
+	info, ok := debug.ReadBuildInfo()
+	if !ok {
+		return nil, errors.New("module support needed")
+	}
+	modName := info.Main.Path
+	resolved := make(map[string]string)
+
+	return func(dir string) (string, error) {
+		if importPath, ok := resolved[dir]; ok {
+			return importPath, nil
+		}
+		packageName := strings.TrimPrefix(dir, root)
+		importPath := path.Join(modName, packageName)
+		resolved[dir] = importPath
+		return importPath, nil
+	}, nil
+}
+
 func main() {
 	rootDir := flag.String("root-dir", defaultRootDir, "Repo root dir.")
 	flag.Parse()
 
+	importPathResolver, err := importPathResolverFunc(*rootDir)
+	if err != nil {
+		logrus.WithError(err).Error("Failed to create the import path resolver.")
+		os.Exit(1)
+	}
+
 	for _, g := range genConfigs {
-		if err := g.gen(*rootDir); err != nil {
+		if err := g.gen(*rootDir, importPathResolver); err != nil {
 			logrus.WithError(err).WithField("fixture", g.out).Error("Failed generating.")
 			os.Exit(1)
 		}

hack/gen-prow-documented/main_test.go

@@ -61,7 +61,7 @@ skip_report: true
 		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			tmpDir := t.TempDir()
-			in, out := tc.name+".in", tc.name+".out"
+			in, out := tc.name+".go", tc.name+".yaml"
 			if err := os.WriteFile(path.Join(tmpDir, in), tc.rawContents, 0644); err != nil {
 				t.Fatalf("Failed creating input: %v", err)
 			}
@@ -73,7 +73,9 @@ skip_report: true
 				out:    out,
 			}
 
-			if err := g.gen(tmpDir); err != nil {
+			if err := g.gen(tmpDir, func(dir string) (string, error) {
+				return "fake", nil
+			}); err != nil {
 				t.Fatalf("Got unexpected error: %v", err)
 			}
 
@@ -87,3 +89,41 @@ skip_report: true
 		})
 	}
 }
+
+func TestImportPathResolver(t *testing.T) {
+	for _, testCase := range []struct {
+		name           string
+		root           string
+		dir            string
+		wantImportPath string
+	}{
+		{
+			name:           "Resolve successfully",
+			root:           "/usr/src/prow",
+			dir:            "/usr/src/prow/cmd/deck",
+			wantImportPath: "sigs.k8s.io/prow/cmd/deck",
+		},
+		{
+			name:           "Root with leading slash",
+			root:           "/usr/src/prow/",
+			dir:            "/usr/src/prow/cmd/deck",
+			wantImportPath: "sigs.k8s.io/prow/cmd/deck",
+		},
+	} {
+		t.Run(testCase.name, func(tt *testing.T) {
+			resolver, err := importPathResolverFunc(testCase.root)
+			if err != nil {
+				tt.Fatalf("Failed to create resolver func: %s", err)
+			}
+
+			importPath, err := resolver(testCase.dir)
+			if err != nil {
+				tt.Fatalf("Failed to resolve %s: %s", testCase.dir, err)
+			}
+
+			if testCase.wantImportPath != importPath {
+				tt.Fatalf("Expected %s but got %s", testCase.wantImportPath, importPath)
+			}
+		})
+	}
+}