[BUG] Declaring device driver API instances have to use the `DEVICE_API` macro

[rexut]

Describe the bug

Related to the Zephyr upstream migration guide for upcoming v4.5: "… The DEVICE_API macro is now mandatory for declaring device driver API instances of any upstream driver class, including in out-of-tree drivers. DEVICE_API_GET now asserts that the API belongs to the requested class, which requires the instance to live in the class’s iterable section. …"

To Reproduce
Steps to reproduce the behavior:

1. create proper west workspace from latest Bridle main branch
2. west twister --verbose --inline-logs --integration --testsuite-root bridle/tests/drivers/gpio --tag sc18is604
3. west twister --verbose --inline-logs --integration --testsuite-root bridle/tests/drivers/i2c --tag sc18is604
4. See error

Expected behavior

Bridle QA Acceptance Test running w/o errors as before.

Impact

This is a showstopper as long as Bridle violates the Zephyr upstream rules.

Logs and console output

… … …
INFO   - 1/2 native_sim/native/64   drivers.gpio.sc18is604   FAILED rc=1 (native 0.005s <host/gnu>)
… … …
Running TESTSUITE sc18is604_gpio_emul
===================================================================
START - test_pin_get
ASSERTION FAIL [({ extern struct gpio_driver_api _gpio_driver_api_list_start[]; extern const uint8_t _gpio_driver_api_ext_end[]; ((const uint8_t *)((const struct gpio_driver_api *)port->api) < _gpio_driver_api_ext_end && (const uint8_t *)((const struct gpio_driver_api *)port->api) >= (const uint8_t *)_gpio_driver_api_list_start); })] @ WEST_TOPDIR/zephyr/include/zephyr/drivers/gpio.h:1002
	device API is not gpio
@ WEST_TOPDIR/zephyr/lib/os/assert.c:43
… … …

… … …
INFO   - 1/2 native_sim/native/64   drivers.i2c.sc18is604   FAILED rc=1 (native 0.005s <host/gnu>)
… … …
Running TESTSUITE sc18is604_i2c_emul
===================================================================
START - test_read
ASSERTION FAIL [({ extern struct i2c_driver_api _i2c_driver_api_list_start[]; extern const uint8_t _i2c_driver_api_ext_end[]; ((const uint8_t *)((const struct i2c_driver_api *)dev->api) < _i2c_driver_api_ext_end && (const uint8_t *)((const struct i2c_driver_api *)dev->api) >= (const uint8_t *)_i2c_driver_api_list_start); })] @ WEST_TOPDIR/zephyr/include/zephyr/drivers/i2c.h:912
	device API is not i2c
@ WEST_TOPDIR/zephyr/lib/os/assert.c:43
… … …

Screenshots
Non.

Development Environment (please complete the following information):

• OS: Linux (Ubuntu 20.04.6 LTS)
• Toolchain: Zephyr SDK 1.0.1
• Bridle main, Commit SHA 6fa141e

Additional context
Non. — @Irockasingranite FYIO

[rexut]

List of affected drivers

Related to zephyrproject-rtos/zephyr#103176 following set of Bridle owns out-of-tree drivers have to refactoring:

DISPLAY:

• Generic latched SIPO/MUX display controller
  

  bridle/drivers/display/display_sipomux.c

  Lines 198 to 208 in 6fa141e

  	static const struct display_driver_api display_sipomux_api = {
  	.blanking_on = display_sipomux_blanking_on,
  	.blanking_off = display_sipomux_blanking_off,
  	.write = display_sipomux_write,
  	.read = display_sipomux_read,
  	.get_framebuffer = display_sipomux_get_framebuffer,
  	.set_brightness = display_sipomux_set_brightness,
  	.set_contrast = display_sipomux_set_contrast,
  	.get_capabilities = display_sipomux_get_capabilities,
  	.set_pixel_format = display_sipomux_set_pixel_format,
  	};

GPIO:

• PCA9554 I2C-based GPIO chip (w/regrst)
  

  bridle/drivers/gpio/gpio_pca9554_regrst.c

  Lines 554 to 565 in 6fa141e

  	static const struct gpio_driver_api gpio_pca9554_regrst_drv_api_funcs = {
  	.pin_configure = gpio_pca9554_regrst_config,
  	.port_get_raw = gpio_pca9554_regrst_port_get_raw,
  	.port_set_masked_raw = gpio_pca9554_regrst_port_set_masked_raw,
  	.port_set_bits_raw = gpio_pca9554_regrst_port_set_bits_raw,
  	.port_clear_bits_raw = gpio_pca9554_regrst_port_clear_bits_raw,
  	.port_toggle_bits = gpio_pca9554_regrst_port_toggle_bits,
  	.pin_interrupt_configure = gpio_pca9554_regrst_pin_interrupt_configure,
  	#ifdef CONFIG_GPIO_PCA9554_REGRST_INTERRUPT
  	.manage_callback = gpio_pca9554_regrst_manage_callback,
  	#endif
  	};

• PCA9555 I2C-based GPIO chip (w/regrst)
  

  bridle/drivers/gpio/gpio_pca9555_regrst.c

  Lines 558 to 569 in 6fa141e

  	static const struct gpio_driver_api gpio_pca9555_regrst_drv_api_funcs = {
  	.pin_configure = gpio_pca9555_regrst_config,
  	.port_get_raw = gpio_pca9555_regrst_port_get_raw,
  	.port_set_masked_raw = gpio_pca9555_regrst_port_set_masked_raw,
  	.port_set_bits_raw = gpio_pca9555_regrst_port_set_bits_raw,
  	.port_clear_bits_raw = gpio_pca9555_regrst_port_clear_bits_raw,
  	.port_toggle_bits = gpio_pca9555_regrst_port_toggle_bits,
  	.pin_interrupt_configure = gpio_pca9555_regrst_pin_interrupt_configure,
  	#ifdef CONFIG_GPIO_PCA9555_REGRST_INTERRUPT
  	.manage_callback = gpio_pca9555_regrst_manage_callback,
  	#endif
  	};

• NXP SC16IS75x GPIO driver
  

  bridle/drivers/gpio/gpio_sc16is75x.c

  Lines 466 to 477 in 6fa141e

  	static const struct gpio_driver_api gpio_sc16is75x_api = {
  	.pin_configure = gpio_sc16is75x_pin_configure,
  	.port_get_raw = gpio_sc16is75x_port_get_raw,
  	.port_set_masked_raw = gpio_sc16is75x_port_set_masked_raw,
  	.port_set_bits_raw = gpio_sc16is75x_port_set_bits_raw,
  	.port_clear_bits_raw = gpio_sc16is75x_port_clear_bits_raw,
  	.port_toggle_bits = gpio_sc16is75x_port_toggle_bits,
  	#ifdef CONFIG_GPIO_SC16IS75X_INTERRUPTS
  	.pin_interrupt_configure = gpio_sc16is75x_pin_interrupt_configure,
  	.manage_callback = gpio_sc16is75x_manage_callback,
  	#endif /* CONFIG_GPIO_SC16IS75X_INTERRUPTS */
  	};

• GPIO controller part of an SC18IS604 bridge
  

  bridle/drivers/gpio/gpio_sc18is604.c

  Lines 327 to 334 in 6fa141e

  	static const struct gpio_driver_api gpio_sc18is604_api = {
  	.pin_configure = gpio_sc18is604_pin_configure,
  	.port_get_raw = gpio_sc18is604_get_raw,
  	.port_set_masked_raw = gpio_sc18is604_set_masked_raw,
  	.port_set_bits_raw = gpio_sc18is604_set_bits_raw,
  	.port_clear_bits_raw = gpio_sc18is604_clear_bits_raw,
  	.port_toggle_bits = gpio_sc18is604_toggle_bits,
  	};

• Generic latched SIPO/MUX GPIO controller
  

  bridle/drivers/gpio/gpio_sipomux.c

  Lines 210 to 217 in 6fa141e

  	static const struct gpio_driver_api gpio_sipomux_api = {
  	.pin_configure = gpio_sipomux_configure,
  	.port_get_raw = gpio_sipomux_port_get_raw,
  	.port_set_masked_raw = gpio_sipomux_port_set_masked_raw,
  	.port_set_bits_raw = gpio_sipomux_port_set_bits_raw,
  	.port_clear_bits_raw = gpio_sipomux_port_clear_bits_raw,
  	.port_toggle_bits = gpio_sipomux_port_toggle_bits,
  	};

I2C:

• I2C controller part of an SC18IM604 bridge
  

  bridle/drivers/i2c/i2c_sc18is604.c

  Lines 345 to 352 in 6fa141e

  	static const struct i2c_driver_api i2c_sc18is604_api = {
  	.configure = i2c_sc18is604_configure,
  	.get_config = i2c_sc18is604_get_config,
  	.transfer = i2c_sc18is604_transfer,
  	#ifdef CONFIG_I2C_CALLBACK
  	.transfer_cb = i2c_sc18is604_transfer_cb,
  	#endif /* CONFIG_I2C_CALLBACK */
  	};

SERIAL:

• NXP SC16IS75x UART driver
  

  bridle/drivers/serial/uart_sc16is75x.c

  Lines 1003 to 1058 in 6fa141e

  	static const struct uart_driver_api uart_sc16is75x_api = {
  	.poll_in = uart_sc16is75x_poll_in,
  	.poll_out = uart_sc16is75x_poll_out,
  	#ifdef CONFIG_UART_WIDE_DATA
  	.poll_in_u16 = uart_sc16is75x_poll_in_u16,
  	.poll_out_u16 = uart_sc16is75x_poll_out_u16,
  	#endif /* CONFIG_UART_WIDE_DATA */
  	.err_check = uart_sc16is75x_err_check,
  	#ifdef CONFIG_UART_USE_RUNTIME_CONFIGURE
  	.configure = uart_sc16is75x_configure,
  	.config_get = uart_sc16is75x_config_get,
  	#endif /* CONFIG_UART_USE_RUNTIME_CONFIGURE */
  	#ifdef CONFIG_UART_LINE_CTRL
  	.line_ctrl_set = uart_sc16is75x_line_ctrl_set,
  	.line_ctrl_get = uart_sc16is75x_line_ctrl_get,
  	#endif /* CONFIG_UART_LINE_CTRL */
  	#ifdef CONFIG_UART_SC16IS75X_INTERRUPT_DRIVEN
  	.fifo_fill = uart_sc16is75x_fifo_fill,
  	.fifo_read = uart_sc16is75x_fifo_read,
  	#ifdef CONFIG_UART_WIDE_DATA
  	.fifo_fill_u16 = uart_sc16is75x_fifo_fill_u16,
  	.fifo_read_u16 = uart_sc16is75x_fifo_read_u16,
  	#endif /* CONFIG_UART_WIDE_DATA */
  	.irq_tx_enable = uart_sc16is75x_irq_tx_enable,
  	.irq_tx_disable = uart_sc16is75x_irq_tx_disable,
  	.irq_tx_ready = uart_sc16is75x_irq_tx_ready,
  	.irq_tx_complete = uart_sc16is75x_irq_tx_complete,
  	.irq_rx_enable = uart_sc16is75x_irq_rx_enable,
  	.irq_rx_disable = uart_sc16is75x_irq_rx_disable,
  	.irq_rx_ready = uart_sc16is75x_irq_rx_ready,
  	.irq_err_enable = uart_sc16is75x_irq_err_enable,
  	.irq_err_disable = uart_sc16is75x_irq_err_disable,
  	.irq_is_pending = uart_sc16is75x_irq_is_pending,
  	.irq_callback_set = uart_sc16is75x_irq_callback_set,
  	#endif /* CONFIG_UART_SC16IS75X_INTERRUPT_DRIVEN */
  	#ifdef CONFIG_UART_ASYNC_API
  	.callback_set = uart_sc16is75x_callback_set, /* Not supported */
  	.tx = NULL,
  	.tx_abort = NULL,
  	.rx_enable = NULL,
  	.rx_buf_rsp = NULL,
  	.rx_disable = NULL,
  	#ifdef CONFIG_UART_WIDE_DATA
  	.tx_u16 = NULL,
  	.rx_enable_u16 = NULL,
  	.rx_buf_rsp_u16 = NULL,
  	#endif /* CONFIG_UART_WIDE_DATA */
  	#endif /* CONFIG_UART_ASYNC_API */
  	#ifdef CONFIG_UART_DRV_CMD
  	.uart_sc16is75x_drv_cmd = uart_sc16is75x_drv_cmd,
  	#endif /* CONFIG_UART_DRV_CMD */
  	};