Skip to content

Commit 2975409

Browse files
Merge pull request #17 from tiagofilipenunes/improve-settings
Improve settings and update pixelmatch
2 parents 5cf8a35 + 5d1853a commit 2975409

10 files changed

Lines changed: 1057 additions & 1030 deletions

File tree

e2e/diff.spec.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,12 @@ test("Check settings page contains right header and labels", async ({
1818
await page.goto(`chrome-extension://${extensionId}/src/popup/index.html`);
1919
await expect(page.locator("h1")).toContainText("Settings");
2020
expect(page.locator("form > label")).toHaveText([
21+
"Threshold",
22+
"Alpha",
2123
"Diff Color",
24+
"Alt Diff Color",
25+
"AA Color",
26+
"Include AA",
2227
"Default Algo",
2328
]);
2429
});

e2e/fixtures.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@ export const test = base.extend<{
1111
context: BrowserContext;
1212
extensionId: string;
1313
}>({
14-
context: async ({ headless }, use) => {
14+
context: async ({}, use) => {
1515
const pathToExtension = path.join(rootPath, "dist");
1616
const context = await chromium.launchPersistentContext("", {
17-
headless,
17+
channel: "chromium",
1818
args: [
19-
...(headless ? ["--headless=new"] : []),
2019
`--disable-extensions-except=${pathToExtension}`,
2120
`--load-extension=${pathToExtension}`,
2221
],

package.json

Lines changed: 18 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"displayName": "Better GitHub Image Diff",
55
"description": "The Better Github Image Diff Chromium/Firefox extension improves the image diff experience on GitHub `Files Changed` view.",
66
"private": true,
7-
"version": "1.3.2",
7+
"version": "1.4.0",
88
"type": "module",
99
"packageManager": "pnpm@9.11.0",
1010
"scripts": {
@@ -28,25 +28,24 @@
2828
"e2e": "pnpm build:chromium && pnpm playwright test"
2929
},
3030
"devDependencies": {
31-
"@commitlint/cli": "^19.3.0",
32-
"@commitlint/config-conventional": "^19.2.2",
33-
"@playwright/test": "^1.47.2",
34-
"@types/fs-extra": "^11.0.4",
35-
"@types/node": "^20.12.7",
36-
"@types/pixelmatch": "^5.2.6",
37-
"@types/webextension-polyfill": "^0.12.1",
38-
"cross-env": "^7.0.3",
39-
"fs-extra": "^11.2.0",
40-
"husky": "^9.0.11",
41-
"rimraf": "^6.0.1",
42-
"tsx": "^4.19.0",
43-
"typescript": "^5.2.2",
44-
"unplugin-auto-import": "^0.18.3",
45-
"vite": "^5.4.8",
46-
"web-ext": "^8.3.0",
47-
"webextension-polyfill": "^0.12.0"
31+
"@commitlint/cli": "19.8.1",
32+
"@commitlint/config-conventional": "19.8.1",
33+
"@playwright/test": "1.52.0",
34+
"@types/fs-extra": "11.0.4",
35+
"@types/node": "22.14.0",
36+
"@types/webextension-polyfill": "0.12.3",
37+
"cross-env": "7.0.3",
38+
"fs-extra": "11.3.0",
39+
"husky": "9.1.7",
40+
"rimraf": "6.0.1",
41+
"tsx": "4.19.4",
42+
"typescript": "5.8.3",
43+
"unplugin-auto-import": "0.18.3",
44+
"vite": "5.4.8",
45+
"web-ext": "8.7.1",
46+
"webextension-polyfill": "0.12.0"
4847
},
4948
"dependencies": {
50-
"pixelmatch": "^5.3.0"
49+
"pixelmatch": "7.1.0"
5150
}
5251
}

0 commit comments

Comments
 (0)