Skip to content

Commit a108af5

Browse files
author
Archit Aggarwal
authored
Remove debug log that can be problematic for non-blocking transport implementations (FreeRTOS#167)
The debug-level log that is printed on not receiving any data from the network (when the first byte of an MQTT packet is attempted for reading) can be problematic when the transport interface TransportInterfaceRecv_t function is implemented in non-blocking behavior. The problem it will cause is overwhelming logging of the message when MQTT_ProcessLoop API is called with a non-zero timeout (or the API is called multiple times with zero timeout but within a loop until some data is achieved). Due to over-logging of this message, the DEBUG logging level configured build of the coreMQTT library will be non-valuable. This PR removes the problematic log statement.
1 parent 8786f32 commit a108af5

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

source/core_mqtt_serializer.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2390,7 +2390,6 @@ MQTTStatus_t MQTT_GetIncomingPacketTypeAndLength( TransportRecv_t readFunc,
23902390
}
23912391
else if( ( status != MQTTBadParameter ) && ( bytesReceived == 0 ) )
23922392
{
2393-
LogDebug( ( "No data was received from the transport." ) );
23942393
status = MQTTNoDataAvailable;
23952394
}
23962395

0 commit comments

Comments
 (0)