Commit 30d2f8b
authored
fix a bug in artificial viscosity (quokka-astro#1605)
### Description
In the current implementation of artificial viscosity, the viscosity
term is added in the wrong direction. This PR fixes the bug by using the
variable `F_canonical` to store intermediate fluxes and then applying
the correct permutation.
### Related issues
Are there any GitHub issues that are fixed by this pull request? Add a
link to them here.
### Checklist
_Before this pull request can be reviewed, all of these tasks should be
completed. Denote completed tasks with an `x` inside the square brackets
`[ ]` in the Markdown source below:_
- [x] I have added a description (see above).
- [ ] I have added a link to any related issues (if applicable; see
above).
- [ ] I have read the [Contributing
Guide](https://github.com/quokka-astro/quokka/blob/development/CONTRIBUTING.md).
- [ ] I have added tests for any new physics that this PR adds to the
code.
- [x] *(For quokka-astro org members)* I have manually triggered the GPU
tests with the magic comment `/azp run`.1 parent a47a6a4 commit 30d2f8b
1 file changed
Lines changed: 8 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1410 | 1410 | | |
1411 | 1411 | | |
1412 | 1412 | | |
1413 | | - | |
1414 | | - | |
1415 | | - | |
1416 | | - | |
1417 | | - | |
1418 | | - | |
1419 | | - | |
1420 | 1413 | | |
1421 | 1414 | | |
1422 | 1415 | | |
| |||
1441 | 1434 | | |
1442 | 1435 | | |
1443 | 1436 | | |
1444 | | - | |
| 1437 | + | |
| 1438 | + | |
| 1439 | + | |
| 1440 | + | |
| 1441 | + | |
| 1442 | + | |
| 1443 | + | |
| 1444 | + | |
1445 | 1445 | | |
1446 | 1446 | | |
1447 | 1447 | | |
| |||
0 commit comments