Skip to content

Commit ececf5a

Browse files
chongchonghepre-commit-ci[bot]
chongchonghe
and
pre-commit-ci[bot]
authored
Runtime BC control for both cc and fc variables (quokka-astro#1516)
### Description Now, we define boundary conditions with a single runtime parameter. This overrides `geometry.is_periodic = 1 1 1`. No need for `BCs_cc` in the problem creator. ``` quokka.bc = periodic periodic reflecting ``` ### Checklist _Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an `x` inside the square brackets `[ ]` in the Markdown source below:_ - [ ] I have added a description (see above). - [ ] I have added a link to any related issues (if applicable; see above). - [ ] I have read the [Contributing Guide](https://github.com/quokka-astro/quokka/blob/development/CONTRIBUTING.md). - [ ] I have added tests for any new physics that this PR adds to the code. - [ ] *(For quokka-astro org members)* I have manually triggered the GPU tests with the magic comment `/azp run`. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 9f62765 commit ececf5a

178 files changed

Lines changed: 338 additions & 560 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎docs/markdown/mhd_module.md‎

Lines changed: 1 addition & 1 deletion

‎inputs/Advection.in‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# *****************************************************************
44
geometry.prob_lo = 0.0 0.0 0.0
55
geometry.prob_hi = 1.0 1.0 1.0
6-
geometry.is_periodic = 1 1 1
6+
quokka.bc = periodic periodic periodic
77

88
# *****************************************************************
99
# VERBOSITY

‎inputs/Advection2D.in‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# *****************************************************************
44
geometry.prob_lo = 0.0 0.0 0.0
55
geometry.prob_hi = 1.0 1.0 1.0
6-
geometry.is_periodic = 1 1 1
6+
quokka.bc = periodic periodic periodic
77

88
# *****************************************************************
99
# VERBOSITY

‎inputs/AdvectionSemiellipse.in‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# *****************************************************************
44
geometry.prob_lo = 0.0 0.0 0.0
55
geometry.prob_hi = 1.0 1.0 1.0
6-
geometry.is_periodic = 1 1 1
6+
quokka.bc = periodic periodic periodic
77

88
# *****************************************************************
99
# VERBOSITY

‎inputs/AlfvenWaveCircular.in‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# *****************************************************************
44
geometry.prob_lo = 0.0 0.0 0.0
55
geometry.prob_hi = 1.0 1.0 1.0
6-
geometry.is_periodic = 1 1 1
6+
quokka.bc = periodic periodic periodic
77

88
# *****************************************************************
99
# VERBOSITY

‎inputs/AlfvenWaveLinear.in‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# *****************************************************************
44
geometry.prob_lo = 0.0 0.0 0.0
55
geometry.prob_hi = 1.0 1.0 1.0
6-
geometry.is_periodic = 1 1 1
6+
quokka.bc = periodic periodic periodic
77

88
# *****************************************************************
99
# VERBOSITY

‎inputs/BinaryOrbitAMR.in‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# *****************************************************************
44
geometry.prob_lo = -2.5e13 -2.5e13 -2.5e13
55
geometry.prob_hi = 2.5e13 2.5e13 2.5e13
6-
geometry.is_periodic = 1 0 0
6+
quokka.bc = periodic periodic reflecting
77

88
# *****************************************************************
99
# VERBOSITY

‎inputs/BinaryOrbitCIC.in‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# *****************************************************************
44
geometry.prob_lo = -2.5e13 -2.5e13 -2.5e13
55
geometry.prob_hi = 2.5e13 2.5e13 2.5e13
6-
geometry.is_periodic = 1 1 0
6+
quokka.bc = periodic periodic reflecting
77

88
# *****************************************************************
99
# VERBOSITY
@@ -30,5 +30,5 @@ plotfile_interval = -1
3030
tiny_profiler.enabled = 0
3131

3232
cfl = 0.3
33-
max_timesteps = 2000
33+
max_timesteps = 20
3434
stop_time = 5.0e7 # s

‎inputs/BinaryOrbit_refactor.in‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# *****************************************************************
44
geometry.prob_lo = -2.5e13 -2.5e13 -2.5e13
55
geometry.prob_hi = 2.5e13 2.5e13 2.5e13
6-
geometry.is_periodic = 1 1 1
6+
quokka.bc = periodic periodic periodic
77

88
# *****************************************************************
99
# VERBOSITY

‎inputs/BinaryOrbit_refactor_init.in‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# *****************************************************************
44
geometry.prob_lo = -2.5e13 -2.5e13 -2.5e13
55
geometry.prob_hi = 2.5e13 2.5e13 2.5e13
6-
geometry.is_periodic = 1 1 1
6+
quokka.bc = periodic periodic periodic
77

88
# *****************************************************************
99
# VERBOSITY

0 commit comments

Comments
 (0)